From 6f8adb09aa2e03e0876b36bcf6c309f373e8abad Mon Sep 17 00:00:00 2001 From: Victor Oomens Date: Sat, 28 Jan 2023 15:00:13 +0100 Subject: [PATCH 1/2] Fix box fingerprint init This fixes an issue where finger print visibility is set to false --- .../kevalpatel/passcodeview/internal/BasePasscodeView.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/passcodeview/src/main/java/com/kevalpatel/passcodeview/internal/BasePasscodeView.java b/passcodeview/src/main/java/com/kevalpatel/passcodeview/internal/BasePasscodeView.java index e94d789..e8116d2 100644 --- a/passcodeview/src/main/java/com/kevalpatel/passcodeview/internal/BasePasscodeView.java +++ b/passcodeview/src/main/java/com/kevalpatel/passcodeview/internal/BasePasscodeView.java @@ -147,7 +147,6 @@ public BasePasscodeView(@NonNull final Context context, * @param attrs {@link AttributeSet} */ private void init(@Nullable final AttributeSet attrs) { - mBoxFingerprint.init(); init(); //Call init for the concrete class if (attrs != null) { //Parse all the params from the arguments. @@ -173,6 +172,9 @@ private void init(@Nullable final AttributeSet attrs) { mBoxFingerprint.setDefaults(); setDefaults(); } + + // Initialze BoxFingerprint AFTER setting attrs!!!! + mBoxFingerprint.init(); //Prepare paints. prepareDividerPaint(); From 7e5786281f5e9f021eb29fbde129b56888ae8642 Mon Sep 17 00:00:00 2001 From: Victor Oomens Date: Mon, 30 Jan 2023 13:25:00 +0100 Subject: [PATCH 2/2] Create gradle-publish.yml --- .github/workflows/gradle-publish.yml | 45 ++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 .github/workflows/gradle-publish.yml diff --git a/.github/workflows/gradle-publish.yml b/.github/workflows/gradle-publish.yml new file mode 100644 index 0000000..42eae27 --- /dev/null +++ b/.github/workflows/gradle-publish.yml @@ -0,0 +1,45 @@ +# This workflow uses actions that are not certified by GitHub. +# They are provided by a third-party and are governed by +# separate terms of service, privacy policy, and support +# documentation. +# This workflow will build a package using Gradle and then publish it to GitHub packages when a release is created +# For more information see: https://github.com/actions/setup-java/blob/main/docs/advanced-usage.md#Publishing-using-gradle + +name: Gradle Package + +on: + release: + types: [created] + +jobs: + build: + + runs-on: ubuntu-latest + permissions: + contents: read + packages: write + + steps: + - uses: actions/checkout@v3 + - name: Set up JDK 11 + uses: actions/setup-java@v3 + with: + java-version: '11' + distribution: 'temurin' + server-id: github # Value of the distributionManagement/repository/id field of the pom.xml + settings-path: ${{ github.workspace }} # location for the settings.xml file + + - name: Build with Gradle + uses: gradle/gradle-build-action@67421db6bd0bf253fb4bd25b31ebb98943c375e1 + with: + arguments: build + + # The USERNAME and TOKEN need to correspond to the credentials environment variables used in + # the publishing section of your build.gradle + - name: Publish to GitHub Packages + uses: gradle/gradle-build-action@67421db6bd0bf253fb4bd25b31ebb98943c375e1 + with: + arguments: publish + env: + USERNAME: ${{ github.actor }} + TOKEN: ${{ secrets.GITHUB_TOKEN }}