chore: delete totalcoherent references, delete computecoherence test, improve level calculation

Author: kemuru

subgraph/core/src/entities/User.ts

@@ -1,20 +1,6 @@
-import { BigInt, BigDecimal } from "@graphprotocol/graph-ts";
 import { User } from "../../generated/schema";
 import { ONE, ZERO } from "../utils";
 
-export function computeCoherenceScore(totalCoherent: BigInt, totalResolvedDisputes: BigInt): BigInt {
-  const smoothingFactor = BigDecimal.fromString("10");
-
-  let denominator = totalResolvedDisputes.toBigDecimal().plus(smoothingFactor);
-  let coherencyRatio = totalCoherent.toBigDecimal().div(denominator);
-
-  const coherencyScore = coherencyRatio.times(BigDecimal.fromString("100"));
-
-  const roundedScore = coherencyScore.plus(BigDecimal.fromString("0.5"));
-
-  return BigInt.fromString(roundedScore.toString().split(".")[0]);
-}
-
 export function ensureUser(id: string): User {
   const user = User.load(id);
 

subgraph/core/tests/user.test.ts

@@ -1,31 +1,29 @@
-export const levelTitles = [
-  { level: 0, title: "Diogenes" },
-  { level: 1, title: "Pythagoras" },
-  { level: 2, title: "Socrates" },
-  { level: 3, title: "Plato" },
-  { level: 4, title: "Aristotle" },
+interface ILevelCriteria {
+  level: number;
+  title: string;
+  minDisputes: number;
+  minScore: number;
+  maxScore: number;
+}
+
+const levelCriteria: ILevelCriteria[] = [
+  { level: 0, title: "Diogenes", minDisputes: 3, minScore: 0, maxScore: 49 },
+  { level: 1, title: "Pythagoras", minDisputes: 0, minScore: 0, maxScore: 70 },
+  { level: 2, title: "Socrates", minDisputes: 3, minScore: 71, maxScore: 80 },
+  { level: 3, title: "Plato", minDisputes: 7, minScore: 81, maxScore: 90 },
+  { level: 4, title: "Aristotle", minDisputes: 10, minScore: 91, maxScore: 100 },
 ];
 
 export const getUserLevelData = (coherencyScore: number, totalResolvedDisputes: number) => {
-  if (totalResolvedDisputes >= 3 && coherencyScore < 50) {
-    return levelTitles.find(({ level }) => level === 0);
-  }
-
-  if (totalResolvedDisputes === 0 || (totalResolvedDisputes >= 1 && coherencyScore >= 0 && coherencyScore <= 70)) {
-    return levelTitles.find(({ level }) => level === 1);
-  }
-
-  if (totalResolvedDisputes >= 3 && coherencyScore > 70 && coherencyScore <= 80) {
-    return levelTitles.find(({ level }) => level === 2);
-  }
-
-  if (totalResolvedDisputes >= 7 && coherencyScore > 80 && coherencyScore <= 90) {
-    return levelTitles.find(({ level }) => level === 3);
-  }
-
-  if (totalResolvedDisputes >= 10 && coherencyScore > 90) {
-    return levelTitles.find(({ level }) => level === 4);
+  for (const criteria of levelCriteria) {
+    if (
+      totalResolvedDisputes >= criteria.minDisputes &&
+      coherencyScore >= criteria.minScore &&
+      coherencyScore <= criteria.maxScore
+    ) {
+      return levelCriteria.find(({ level }) => level === criteria.level);
+    }
   }
 
-  return levelTitles.find(({ level }) => level === 1);
+  return levelCriteria.find(({ level }) => level === 1);
 };