chore: renamed the constant MIN_JURORS to DEFAULT_NB_OF_JURORS

Author: jaybuidl

contracts/src/arbitration/KlerosCore.sol

@@ -95,7 +95,7 @@ contract KlerosCore is IArbitrator {
     uint96 public constant GENERAL_COURT = 1; // Index of the default (general) court.
     uint256 public constant NULL_DISPUTE_KIT = 0; // Null pattern to indicate a top-level DK which has no parent.
     uint256 public constant DISPUTE_KIT_CLASSIC = 1; // Index of the default DK. 0 index is skipped.
-    uint256 public constant MIN_JURORS = 3; // The global default minimum number of jurors in a dispute.
+    uint256 public constant DEFAULT_NB_OF_JURORS = 3; // The default number of jurors in a dispute.
     uint256 public constant ALPHA_DIVISOR = 1e4; // The number to divide `Court.alpha` by.
     uint256 public constant NON_PAYABLE_AMOUNT = (2 ** 256 - 2) / 2; // An amount higher than the supply of ETH.
     uint256 public constant SEARCH_ITERATIONS = 10; // Number of iterations to search for suitable parent court before jumping to the top court.
@@ -1109,14 +1109,14 @@ contract KlerosCore is IArbitrator {
                 courtID = GENERAL_COURT;
             }
             if (minJurors == 0) {
-                minJurors = MIN_JURORS;
+                minJurors = DEFAULT_NB_OF_JURORS;
             }
             if (disputeKitID == NULL_DISPUTE_KIT || disputeKitID >= disputeKitNodes.length) {
                 disputeKitID = DISPUTE_KIT_CLASSIC; // 0 index is not used.
             }
         } else {
             courtID = GENERAL_COURT;
-            minJurors = MIN_JURORS;
+            minJurors = DEFAULT_NB_OF_JURORS;
             disputeKitID = DISPUTE_KIT_CLASSIC;
         }
     }

contracts/src/gateway/ForeignGateway.sol

@@ -45,7 +45,7 @@ contract ForeignGateway is IForeignGateway {
     // *             Storage               * //
     // ************************************* //
 
-    uint256 public constant MIN_JURORS = 3; // The global default minimum number of jurors in a dispute.
+    uint256 public constant DEFAULT_NB_OF_JURORS = 3; // The default number of jurors in a dispute.
     uint256 internal localDisputeID = 1; // The disputeID must start from 1 as the KlerosV1 proxy governor depends on this implementation. We now also depend on localDisputeID not ever being zero.
     mapping(uint96 => uint256) public feeForJuror; // feeForJuror[courtID], it mirrors the value on KlerosCore.
     address public governor;
@@ -222,10 +222,10 @@ contract ForeignGateway is IForeignGateway {
                 minJurors := mload(add(_extraData, 0x40))
             }
             if (feeForJuror[courtID] == 0) courtID = 0;
-            if (minJurors == 0) minJurors = MIN_JURORS;
+            if (minJurors == 0) minJurors = DEFAULT_NB_OF_JURORS;
         } else {
             courtID = 0;
-            minJurors = MIN_JURORS;
+            minJurors = DEFAULT_NB_OF_JURORS;
         }
     }
 }

contracts/src/gateway/ForeignGatewayOnGnosis.sol

@@ -46,7 +46,7 @@ contract ForeignGatewayOnGnosis is IForeignGateway {
     // *             Storage               * //
     // ************************************* //
 
-    uint256 public constant MIN_JURORS = 3; // The global default minimum number of jurors in a dispute.
+    uint256 public constant DEFAULT_NB_OF_JURORS = 3; // The default number of jurors in a dispute.
     IERC20 public immutable weth; // WETH token on xDai.
     uint256 internal localDisputeID = 1; // The disputeID must start from 1 as the KlerosV1 proxy governor depends on this implementation. We now also depend on localDisputeID not ever being zero.
     mapping(uint96 => uint256) public feeForJuror; // feeForJuror[courtID], it mirrors the value on KlerosCore.
@@ -226,10 +226,10 @@ contract ForeignGatewayOnGnosis is IForeignGateway {
                 minJurors := mload(add(_extraData, 0x40))
             }
             if (feeForJuror[courtID] == 0) courtID = 0;
-            if (minJurors == 0) minJurors = MIN_JURORS;
+            if (minJurors == 0) minJurors = DEFAULT_NB_OF_JURORS;
         } else {
             courtID = 0;
-            minJurors = MIN_JURORS;
+            minJurors = DEFAULT_NB_OF_JURORS;
         }
     }
 }

contracts/src/kleros-v1/kleros-liquid-xdai/xKlerosLiquidV2.sol

@@ -138,7 +138,7 @@ contract xKlerosLiquidV2 is Initializable, ITokenController, IArbitrator {
 
     // General Constants
     uint256 public constant MAX_STAKE_PATHS = 4; // The maximum number of stake paths a juror can have.
-    uint256 public constant MIN_JURORS = 3; // The global default minimum number of jurors in a dispute.
+    uint256 public constant DEFAULT_NB_OF_JURORS = 3; // The default number of jurors in a dispute.
     uint256 public constant NON_PAYABLE_AMOUNT = (2 ** 256 - 2) / 2; // An amount higher than the supply of ETH.
     uint256 public constant ALPHA_DIVISOR = 1e4; // The number to divide `Court.alpha` by.
     // General Contracts
@@ -579,10 +579,10 @@ contract xKlerosLiquidV2 is Initializable, ITokenController, IArbitrator {
                 minJurors := mload(add(_extraData, 0x40))
             }
             if (subcourtID >= courts.length) subcourtID = 0;
-            if (minJurors == 0) minJurors = MIN_JURORS;
+            if (minJurors == 0) minJurors = DEFAULT_NB_OF_JURORS;
         } else {
             subcourtID = 0;
-            minJurors = MIN_JURORS;
+            minJurors = DEFAULT_NB_OF_JURORS;
         }
     }