chore: randomizer rng does not need to be upgradable

Author: jaybuidl

contracts/deploy/00-home-chain-arbitration-neo.ts

@@ -36,7 +36,7 @@ const deployArbitration: DeployFunction = async (hre: HardhatRuntimeEnvironment)
     log: true,
   });
 
-  const rng = await deployUpgradable(deployments, "RandomizerRNG", {
+  const rng = await deploy("RandomizerRNG", {
     from: deployer,
     args: [deployer, ZeroAddress, randomizerOracle.target], // The SortitionModule is configured later
     log: true,

contracts/deploy/00-home-chain-arbitration.ts

@@ -36,7 +36,7 @@ const deployArbitration: DeployFunction = async (hre: HardhatRuntimeEnvironment)
     log: true,
   });
 
-  const randomizerRng = await getContractOrDeployUpgradable(hre, "RandomizerRNG", {
+  const randomizerRng = await getContractOrDeploy(hre, "RandomizerRNG", {
     from: deployer,
     args: [deployer, ZeroAddress, randomizerOracle.target], // The SortitionModule is configured later
     log: true,

contracts/deploy/00-rng.ts

@@ -24,7 +24,7 @@ const deployArbitration: DeployFunction = async (hre: HardhatRuntimeEnvironment)
     log: true,
   });
 
-  const rng1 = await deployUpgradable(deployments, "RandomizerRNG", {
+  const rng1 = await deploy("RandomizerRNG", {
     from: deployer,
     args: [deployer, sortitionModule.target, randomizerOracle.address],
     log: true,

contracts/src/rng/RandomizerRNG.sol

@@ -4,12 +4,10 @@ pragma solidity 0.8.24;
 
 import "./RNG.sol";
 import "./IRandomizer.sol";
-import "../proxy/UUPSProxiable.sol";
-import "../proxy/Initializable.sol";
 
 /// @title Random Number Generator that uses Randomizer.ai
 /// https://randomizer.ai/
-contract RandomizerRNG is RNG, UUPSProxiable, Initializable {
+contract RandomizerRNG is RNG {
     // ************************************* //
     // *             Storage               * //
     // ************************************* //
@@ -52,19 +50,10 @@ contract RandomizerRNG is RNG, UUPSProxiable, Initializable {
     // *            Constructor            * //
     // ************************************* //
 
-    /// @dev Constructor, initializing the implementation to reduce attack surface.
-    constructor() {
-        _disableInitializers();
-    }
-
-    /// @dev Initializer
+    /// @dev Constructor
     /// @param _randomizer Randomizer contract.
     /// @param _governor Governor of the contract.
-    function initialize(
-        address _governor,
-        address _sortitionModule,
-        IRandomizer _randomizer
-    ) external reinitializer(1) {
+    constructor(address _governor, address _sortitionModule, IRandomizer _randomizer) {
         governor = _governor;
         sortitionModule = _sortitionModule;
         randomizer = _randomizer;
@@ -75,14 +64,6 @@ contract RandomizerRNG is RNG, UUPSProxiable, Initializable {
     // *      Governance      * //
     // ************************ //
 
-    /**
-     * @dev Access Control to perform implementation upgrades (UUPS Proxiable)
-     * @dev Only the governor can perform upgrades (`onlyByGovernor`)
-     */
-    function _authorizeUpgrade(address) internal view override onlyByGovernor {
-        // NOP
-    }
-
     /// @dev Changes the governor of the contract.
     /// @param _governor The new governor.
     function changeGovernor(address _governor) external onlyByGovernor {

contracts/src/rng/mock/ChainlinkVRFCoordinatorMock.sol

@@ -108,55 +108,6 @@ contract ChainlinkVRFCoordinatorV2Mock is IVRFCoordinatorV2Plus {
         revert("not implemented");
     }
 
-    function getRequestConfig() external pure returns (uint16, uint32, bytes32[] memory) {
-        return (3, 2000000, new bytes32[](0));
-    }
-
-    function getConfig()
-        external
-        pure
-        returns (
-            uint16 minimumRequestConfirmations,
-            uint32 maxGasLimit,
-            uint32 stalenessSeconds,
-            uint32 gasAfterPaymentCalculation
-        )
-    {
-        return (4, 2_500_000, 2_700, 33285);
-    }
-
-    function getFeeConfig()
-        external
-        pure
-        returns (
-            uint32 fulfillmentFlatFeeLinkPPMTier1,
-            uint32 fulfillmentFlatFeeLinkPPMTier2,
-            uint32 fulfillmentFlatFeeLinkPPMTier3,
-            uint32 fulfillmentFlatFeeLinkPPMTier4,
-            uint32 fulfillmentFlatFeeLinkPPMTier5,
-            uint24 reqsForTier2,
-            uint24 reqsForTier3,
-            uint24 reqsForTier4,
-            uint24 reqsForTier5
-        )
-    {
-        return (
-            100000, // 0.1 LINK
-            100000, // 0.1 LINK
-            100000, // 0.1 LINK
-            100000, // 0.1 LINK
-            100000, // 0.1 LINK
-            0,
-            0,
-            0,
-            0
-        );
-    }
-
-    function getFallbackWeiPerUnitLink() external pure returns (int256) {
-        return 4000000000000000; // 0.004 Ether
-    }
-
     function requestSubscriptionOwnerTransfer(uint256, address) external pure {
         revert("not implemented");
     }