fix: coderabbit

Author: jaybuidl

contracts/test/arbitration/draw.ts

@@ -137,6 +137,7 @@ describe("Draw Benchmark", async () => {
     const tx = await arbitrable["createDispute(string)"]("future of france", {
       value: arbitrationCost,
     });
+    await tx.wait();
     if (tx.blockNumber === null) throw new Error("tx.blockNumber is null");
     const trace = await network.provider.send("debug_traceTransaction", [tx.hash]);
     const [disputeId] = abiCoder.decode(["uint"], ethers.getBytes(`${trace.returnValue}`));
@@ -208,6 +209,7 @@ describe("Draw Benchmark", async () => {
       expect(await core.getRoundInfo(0, 0).then((round) => round.drawIterations)).to.equal(3);
 
       const tx = await (await drawTx).wait();
+      if (!tx) throw new Error("Failed to get transaction receipt");
       expect(tx)
         .to.emit(core, "Draw")
         .withArgs(anyValue, 0, 0, 0)
@@ -306,7 +308,7 @@ describe("Draw Benchmark", async () => {
       expect(await core.getRoundInfo(0, 0).then((round) => round.drawIterations)).to.equal(3);
 
       const tx = await (await drawTx).wait();
-      if (tx === null) throw new Error("tx is null");
+      if (!tx) throw new Error("Failed to get transaction receipt");
       expect(tx)
         .to.emit(core, "Draw")
         .withArgs(anyValue, 0, 0, 0)
@@ -368,7 +370,7 @@ describe("Draw Benchmark", async () => {
       expect(await core.getRoundInfo(0, 0).then((round) => round.drawIterations)).to.equal(3);
 
       const tx = await (await drawTx).wait();
-      if (tx === null) throw new Error("tx is null");
+      if (!tx) throw new Error("Failed to get transaction receipt");
       expect(tx)
         .to.emit(core, "Draw")
         .withArgs(anyValue, 0, 0, 0)

contracts/test/integration/index.ts

@@ -129,7 +129,7 @@ describe("Integration tests", async () => {
     );
     console.log("dispute hash: ", disputeHash);
     if (lastBlock.hash === null) {
-      process.exit();
+      throw new Error("Block hash is null - cannot calculate dispute hash");
     }
     // Relayer tx
     const tx2 = await homeGateway

contracts/test/rng/index.ts

@@ -33,16 +33,16 @@ describe("BlockHashRNG", async () => {
   });
 
   it("Should return a non-zero number for a block number in the past", async () => {
-    const tx = await rng.receiveRandomness(9876543210);
+    const tx = await rng.receiveRandomness(5);
     const trace = await network.provider.send("debug_traceTransaction", [tx.hash]);
     const [rn] = abiCoder.decode(["uint"], ethers.getBytes(`${trace.returnValue}`));
-    expect(rn).to.equal(0);
+    expect(rn).to.not.equal(0);
   });
 
   it("Should return zero for a block number in the future", async () => {
-    const tx = await rng.receiveRandomness(5);
+    const tx = await rng.receiveRandomness(9876543210);
     const trace = await network.provider.send("debug_traceTransaction", [tx.hash]);
     const [rn] = abiCoder.decode(["uint"], ethers.getBytes(`${trace.returnValue}`));
-    expect(rn).to.not.equal(0);
+    expect(rn).to.equal(0);
   });
 });