chore: approval changes

Author: Anmol-Dhiman

contracts/deploy/00-home-chain-arbitration-university.ts

@@ -75,7 +75,7 @@ const deployArbitration: DeployFunction = async (hre: HardhatRuntimeEnvironment)
     await changeCurrencyRate(core, await dai.getAddress(), true, 60327783, 11);
     await changeCurrencyRate(core, await weth.getAddress(), true, 1, 1);
   } catch (e) {
-    console.error("failed to change currency rates:", e);
+    console.error("Failed to change currency rates for token, with error:", e);
   }
 
   const disputeTemplateRegistry = await getContractOrDeployUpgradable(hre, "DisputeTemplateRegistry", {

contracts/deploy/03-vea-mock.ts

@@ -49,6 +49,7 @@ const deployHomeGateway: DeployFunction = async (hre: HardhatRuntimeEnvironment)
       HardhatChain.HARDHAT,
       foreignGateway.address,
       ethers.ZeroAddress, // feeToken
+      // Confirm that using ZeroAddress here is intentional and safe for the intended use case.
     ],
     gasLimit: 4000000,
     log: true,

contracts/scripts/keeperBot.ts

@@ -564,11 +564,11 @@ async function main() {
 
   logger.info(`Current phase: ${PHASES[getNumber(await sortition.phase())]}`);
 
-  for (var dispute of disputes) {
+  for (var disputeDetails of disputes) {
     // ----------------------------------------------- //
     //                  PASS PERIOD                    //
     // ----------------------------------------------- //
-    await passPeriod(dispute);
+    await passPeriod(disputeDetails);
   }
 
   // Get all the disputes whose ruling is not yet executed

contracts/scripts/simulations/tasks.ts

@@ -77,11 +77,11 @@ task("simulate:create-court", "callable by Governor only. Create a new Court")
 
     const { wallet } = await getWallet(hre, walletindex);
 
-    const parent = toBigInt(1) as BigNumberish;
-    const minStake = (toBigInt(10) ** toBigInt(20) * toBigInt(2)) as BigNumberish;
-    const alpha = toBigInt(10000) as BigNumberish;
-    const feeForJuror = (toBigInt(10) ** toBigInt(17)) as BigNumberish;
-    const jurorsForCourtJump = toBigInt(3) as BigNumberish;
+    const parent = toBigInt(1);
+    const minStake = toBigInt(10) ** toBigInt(20) * toBigInt(2);
+    const alpha = toBigInt(10000);
+    const feeForJuror = toBigInt(10) ** toBigInt(17);
+    const jurorsForCourtJump = toBigInt(3);
     const hiddenVotes = false as boolean;
     const timesPerPeriod = [300, 300, 300, 300] as [BigNumberish, BigNumberish, BigNumberish, BigNumberish];
     const sortitionSumTreeK = ethers.toBeHex(3);
@@ -254,7 +254,7 @@ task("simulate:cast-commit", "Casts a commit for a drawn juror")
     const salt = "123";
     console.log("salt used on juror %s is: %s", walletindex, salt);
     const generateCommit = (choice: number, justification: string) => {
-      const hash = ethers.solidityPackedKeccak256(["string", "string", "string"], [choice, justification, salt]);
+      const hash = ethers.solidityPackedKeccak256(["uint256", "string", "string"], [choice, justification, salt]);
       return ethers.toBeHex(hash);
     };
     const commitHash = generateCommit(choice, taskArgs.justification);

contracts/test/integration/index.ts

@@ -40,16 +40,16 @@ describe("Integration tests", async () => {
   }
 
   let deployer;
-  let rng: RandomizerRNG,
-    randomizer: RandomizerMock,
-    disputeKit: DisputeKitClassic,
-    pnk: PNK,
-    core: KlerosCore,
-    vea: VeaMock,
-    foreignGateway: ForeignGateway,
-    arbitrable: ArbitrableExample,
-    homeGateway: HomeGateway,
-    sortitionModule: SortitionModule;
+  let rng: RandomizerRNG;
+  let randomizer: RandomizerMock;
+  let disputeKit: DisputeKitClassic;
+  let pnk: PNK;
+  let core: KlerosCore;
+  let vea: VeaMock;
+  let foreignGateway: ForeignGateway;
+  let arbitrable: ArbitrableExample;
+  let homeGateway: HomeGateway;
+  let sortitionModule: SortitionModule;
 
   beforeEach("Setup", async () => {
     ({ deployer } = await getNamedAccounts());