refactor(subgraph): fix code smells

Author: alcercu

subgraph/src/datapoint.ts

@@ -23,27 +23,33 @@ function updateDataPoint(
   const newCounter = new Entity();
   const counter = store.get("Counter", "0");
   for (let i = 0; i < VARIABLES.length; i++) {
-    const targetVar = VARIABLES[i];
-    if (targetVar === variable) {
-      newCounter.set(
-        targetVar,
-        !counter
-          ? Value.fromBigInt(delta)
-          : Value.fromBigInt(counter.get(targetVar)!.toBigInt().plus(delta))
-      );
-    } else {
-      newCounter.set(
-        targetVar,
-        !counter ? Value.fromBigInt(ZERO) : counter.get(VARIABLES[i])!
-      );
-    }
+    const currentVar = VARIABLES[i];
+    newCounter.set(
+      currentVar,
+      getNewValue(currentVar, variable, delta, counter)
+    );
   }
   const dayID = timestamp.toI32() / 86400;
   const dayStartTimestamp = dayID * 86400;
   store.set("Counter", dayStartTimestamp.toString(), newCounter);
   store.set("Counter", "0", newCounter);
 }
 
+function getNewValue(
+  currentVar: string,
+  targetVar: string,
+  delta: BigInt,
+  counter: Entity | null
+): Value {
+  if (currentVar === targetVar) {
+    return !counter
+      ? Value.fromBigInt(delta)
+      : Value.fromBigInt(counter.get(currentVar)!.toBigInt().plus(delta));
+  } else {
+    return !counter ? Value.fromBigInt(ZERO) : counter.get(currentVar)!;
+  }
+}
+
 export function updateStakedPNK(delta: BigInt, timestamp: BigInt): void {
   updateDataPoint(delta, timestamp, "stakedPNK");
 }

subgraph/src/entities/User.ts

@@ -2,7 +2,7 @@ import { User } from "../../generated/schema";
 import { ZERO } from "../utils";
 
 export function ensureUser(id: string): User {
-  let user = User.load(id);
+  const user = User.load(id);
 
   if (user) {
     return user;