Skip to content

Commit a6774ee

Browse files
committed
fix v1.26 update-codegen
1 parent 247f664 commit a6774ee

File tree

5 files changed

+60
-110
lines changed

5 files changed

+60
-110
lines changed

.github/workflows/verify.yml

Lines changed: 1 addition & 86 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ jobs:
371371
run: |
372372
make test-integration
373373
374-
Test-v1-24-6-lts-0:
374+
Test-v1-24-17-lts-0:
375375
needs: Patch
376376
runs-on: ubuntu-latest
377377
steps:
@@ -796,91 +796,6 @@ jobs:
796796
run: |
797797
make test-integration
798798
799-
Test-v1-20-2-lts-2:
800-
needs: Patch
801-
runs-on: ubuntu-latest
802-
steps:
803-
- uses: actions/checkout@v2
804-
- name: Cache
805-
uses: actions/cache@v2
806-
env:
807-
cache-name: src
808-
with:
809-
path: |
810-
src
811-
key: ${{ runner.os }}-build-${{ env.cache-name }}-v1-20-2-lts-2
812-
restore-keys: |
813-
${{ runner.os }}-build-${{ env.cache-name }}
814-
- name: Install dependent
815-
run: |
816-
make dependent
817-
- name: Checkout to v1.20.2-lts.2
818-
run: |
819-
make v1.20.2-lts.2
820-
- name: Install etcd
821-
run: |
822-
make install-etcd
823-
- name: Test
824-
run: |
825-
make test
826-
827-
Test-Cmd-v1-20-2-lts-2:
828-
needs: Patch
829-
runs-on: ubuntu-latest
830-
steps:
831-
- uses: actions/checkout@v2
832-
- name: Cache
833-
uses: actions/cache@v2
834-
env:
835-
cache-name: src
836-
with:
837-
path: |
838-
src
839-
key: ${{ runner.os }}-build-${{ env.cache-name }}-v1-20-2-lts-2
840-
restore-keys: |
841-
${{ runner.os }}-build-${{ env.cache-name }}
842-
- name: Install dependent
843-
run: |
844-
make dependent
845-
- name: Checkout to v1.20.2-lts.2
846-
run: |
847-
make v1.20.2-lts.2
848-
- name: Install etcd
849-
run: |
850-
make install-etcd
851-
- name: Test cmd
852-
run: |
853-
make test-cmd
854-
855-
Test-Integration-v1-20-2-lts-2:
856-
needs: Patch
857-
runs-on: ubuntu-latest
858-
steps:
859-
- uses: actions/checkout@v2
860-
- name: Cache
861-
uses: actions/cache@v2
862-
env:
863-
cache-name: src
864-
with:
865-
path: |
866-
src
867-
/tmp/kubernetes-lts/
868-
key: ${{ runner.os }}-build-${{ env.cache-name }}-v1-20-2-lts-2
869-
restore-keys: |
870-
${{ runner.os }}-build-${{ env.cache-name }}
871-
- name: Install dependent
872-
run: |
873-
make dependent
874-
- name: Checkout to v1.20.2-lts.2
875-
run: |
876-
make v1.20.2-lts.2
877-
- name: Install etcd
878-
run: |
879-
make install-etcd
880-
- name: Test integration
881-
run: |
882-
make test-integration
883-
884799
Test-v1-19-16-lts-3:
885800
needs: Patch
886801
runs-on: ubuntu-latest

Makefile

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,16 @@ format-all-patch:
101101
test:
102102
./hack/test.sh
103103

104+
# before v1.25
104105
.PHONY: test-cmd
105106
test-cmd:
106107
./hack/test_cmd.sh
107108

109+
# after v1.26
110+
.PHONY: test-cmd-2
111+
test-cmd-2:
112+
./hack/test_cmd_2.sh
113+
108114
.PHONY: test-integration
109115
test-integration:
110116
./hack/test_integration.sh

hack/test_cmd_2.sh

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
#!/usr/bin/env bash
2+
3+
set -o errexit
4+
set -o nounset
5+
set -o pipefail
6+
7+
KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
8+
9+
source "kit/helper.sh"
10+
cd "${WORKDIR}"
11+
12+
# Kubeadm was added for testing in 1.19 and later
13+
for n in {1..5}; do
14+
echo "+++ Test retry ${n}"
15+
./build/shell.sh -c '
16+
17+
make all -C "${KUBE_ROOT}" WHAT=cmd/kubeadm
18+
mkdir -p _output/local/go/bin/ && cp _output/dockerized/bin/linux/amd64/kubeadm _output/local/go/bin/
19+
./hack/install-etcd.sh
20+
PATH=$(pwd)/third_party/etcd:${PATH} make test-cmd
21+
' 2>&1 | grep -v -E '^I\w+ ' && exit 0
22+
done

patches/update-kube-proxy-iptables.1.18.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ index 70e3874b441..4c67a178517 100644
2222
},
2323
}
2424
diff --git a/build/common.sh b/build/common.sh
25-
index 9cd95b5af51..13c15466c39 100755
25+
index 75dc82ed335..3771dafdaf5 100755
2626
--- a/build/common.sh
2727
+++ b/build/common.sh
2828
@@ -95,14 +95,14 @@ readonly KUBE_CONTAINER_RSYNC_PORT=8730

releases.yml

Lines changed: 30 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,13 @@ releases:
4949
- fix-kubectl-convert-97644.1.20
5050
- nokmem.1.20
5151

52-
- name: v1.20.2-lts.2
53-
base_release: v1.20.2-ci
54-
must: true
55-
patches:
56-
- fix-kubectl-convert-97644.1.20
57-
- nokmem.1.20
52+
# use v1.20.15-lts.2 instead
53+
# - name: v1.20.2-lts.2
54+
# base_release: v1.20.2-ci
55+
# must: true
56+
# patches:
57+
# - fix-kubectl-convert-97644.1.20
58+
# - nokmem.1.20
5859

5960
- name: v1.19.16-lts.3
6061
base_release: v1.19.16-ci
@@ -64,18 +65,23 @@ releases:
6465
- nokmem.1.20
6566

6667
- name: v1.18.20-lts.2
67-
base_release: v1.18.20-ci
68+
base_release: v1.18.20
6869
must: true
6970
patches:
7071
- CVE-2020-8554.1.18
7172
- fix-missing-env-91500.1.18
7273
- CVE-2021-25741.1.18
7374
- nokmem.1.20
74-
75-
- name: v1.18.20-dce.1
76-
base_release: v1.18.20-lts.2
77-
patches:
78-
- update-kube-proxy-iptables.1.18
75+
76+
# comments this as dce.1 do not needs to be updated
77+
# - name: v1.18.20-dce.1
78+
# base_release: release-1.18
79+
# patches:
80+
# - update-kube-proxy-iptables.1.18
81+
# - CVE-2020-8554.1.18
82+
# - fix-missing-env-91500.1.18
83+
# - CVE-2021-25741.1.18
84+
# - nokmem.1.20
7985

8086
- name: v1.17.17-lts.2
8187
base_release: v1.17.17-ci
@@ -260,17 +266,18 @@ releases:
260266
- k8s.io/kubernetes/pkg/volume/csi
261267
- k8s.io/kubernetes/pkg/util/oom
262268

263-
- name: v1.20.2-ci
264-
base_release: v1.20.2
265-
patches:
266-
- fix-run-docker.1.24
267-
- no-delete-images.1.24
268-
- fix-etcd-put-key.1.23
269-
test_failures_tolerated:
270-
- k8s.io/kubernetes/pkg/kubelet/volumemanager/reconciler
271-
- k8s.io/kubernetes/pkg/volume/csi
272-
- k8s.io/kubernetes/vendor/k8s.io/kube-aggregator/pkg/apiserver
273-
- k8s.io/kubernetes/pkg/util/oom
269+
# use v1.20.15-ci instead
270+
# - name: v1.20.2-ci
271+
# base_release: v1.20.2
272+
# patches:
273+
# - fix-run-docker.1.24
274+
# - no-delete-images.1.24
275+
# - fix-etcd-put-key.1.23
276+
# test_failures_tolerated:
277+
# - k8s.io/kubernetes/pkg/kubelet/volumemanager/reconciler
278+
# - k8s.io/kubernetes/pkg/volume/csi
279+
# - k8s.io/kubernetes/vendor/k8s.io/kube-aggregator/pkg/apiserver
280+
# - k8s.io/kubernetes/pkg/util/oom
274281

275282
- name: v1.19.16-ci
276283
base_release: v1.19.16

0 commit comments

Comments
 (0)