Skip to content

Commit 6dd5cf7

Browse files
committed
feat: update Rust-Python integration guidelines for consistency in class implementations
1 parent 35e213b commit 6dd5cf7

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

AGENTS.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,16 @@ When generating Rust code for DataFusion, follow these guidelines:
4747

4848
3. Follow the standard Rust style conventions from rustfmt
4949

50-
## Rust-backed Classes
50+
## Rust-Python Integration
5151

52-
Some Python classes in this project are thin wrappers around Rust
53-
implementations. If a change affects such a class, update the Rust code
54-
first and then adjust the Python wrappers accordingly.
52+
**Important:** Some classes in this repository have their core implementations in Rust with Python bindings. For any changes related to these classes in Python:
53+
54+
1. **Always update the Rust implementation first** before making corresponding changes to the Python bindings
55+
2. Ensure the Rust changes are properly tested in Rust before updating Python code
56+
3. Update Python bindings to reflect the new Rust API
57+
4. Add or update Python tests to cover the new functionality
58+
59+
This ensures consistency between the Rust core and Python interface, and prevents binding mismatches.
5560

5661
## Code Organization
5762
- Keep functions focused and under about 50 lines.

GEMINI.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ The repository is organized as follows:
3333

3434
## Important Development Note
3535

36-
Some classes in this repository have their core implementations in Rust.
36+
Some Python classes in this repository have their core implementations in Rust.
3737
For any changes related to these classes in Python, ensure the corresponding updates are first made in the Rust implementation.
3838

3939
## How to Build and Test

0 commit comments

Comments
 (0)