Skip to content

Commit beb573b

Browse files
committed
fix: mark from_view method as deprecated and update warning message
1 parent 49c1c5f commit beb573b

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

python/datafusion/table_provider.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
from __future__ import annotations
2020

2121
from typing import Any
22+
import warnings
2223

2324
import datafusion._internal as df_internal
2425

@@ -69,13 +70,19 @@ def from_dataframe(cls, df: Any) -> TableProvider:
6970

7071
@classmethod
7172
def from_view(cls, df: Any) -> TableProvider:
72-
"""Create a :class:`TableProvider` from a DataFrame view."""
73+
"""Deprecated. Use :meth:`DataFrame.into_view` or :meth:`TableProvider.from_dataframe`."""
7374
from datafusion.dataframe import DataFrame as DataFrameWrapper
7475

7576
if isinstance(df, DataFrameWrapper):
7677
df = df.df
7778

7879
provider = _InternalTableProvider.from_view(df)
80+
warnings.warn(
81+
"TableProvider.from_view is deprecated; use DataFrame.into_view or "
82+
"TableProvider.from_dataframe instead.",
83+
DeprecationWarning,
84+
stacklevel=2,
85+
)
7986
return cls(provider)
8087

8188
# ------------------------------------------------------------------

0 commit comments

Comments
 (0)