Merge pull request modelcontextprotocol#15 from major/main

Fix place_first_triggers_second_order with nested JSON

Author: jkoelker

.gitignore

@@ -47,3 +47,23 @@ info/
 
 # Environment files
 .env
+
+# Python
+__pycache__/
+*.py[cod]
+*$py.class
+*.so
+.Python
+.venv
+venv/
+ENV/
+env/
+*.egg
+*.egg-info/
+dist/
+build/
+.pytest_cache/
+.coverage
+htmlcov/
+.mypy_cache/
+.ruff_cache/

src/schwab_mcp/tools/orders.py

@@ -2,6 +2,7 @@
 
 from typing import Annotated, Any, cast
 
+import copy
 import datetime
 from mcp.server.fastmcp import FastMCP
 from schwab.orders.common import first_triggers_second as trigger_builder
@@ -464,11 +465,10 @@ async def place_first_triggers_second_order(
     context: SchwabServerContext = ctx.request_context.lifespan_context
     client = context.orders
 
-    trigger_order_spec = (
-        first_order_spec.copy()
-    )  # Avoid modifying the original input dict
+    # Use deep copy to avoid any reference issues with nested structures
+    trigger_order_spec = copy.deepcopy(first_order_spec)
     trigger_order_spec["orderStrategyType"] = "TRIGGER"
-    trigger_order_spec["childOrderStrategies"] = [second_order_spec]
+    trigger_order_spec["childOrderStrategies"] = [copy.deepcopy(second_order_spec)]
 
     # Place the order
     return await call(

src/schwab_mcp/tools/utils.py

@@ -14,7 +14,17 @@ async def call(func: Callable[..., Awaitable[Any]], *args: Any, **kwargs: Any) -
     response = await func(*args, **kwargs)
     response.raise_for_status()
 
-    if getattr(response, "status_code", None) == 204:
+    # Handle responses with no content
+    # 204 No Content: explicit no-content response
+    # 201 Created: order placement endpoints return empty body with Location header
+    status_code = getattr(response, "status_code", None)
+    if status_code in (201, 204):
+        return None
+
+    # Check if response has content before trying to parse JSON
+    # Some endpoints (like place_order) return empty bodies even with 2xx status
+    content = getattr(response, "content", b"")
+    if not content or len(content) == 0:
         return None
 
     try: