Merge pull request #1871 from kube-logging/feat/validate-syslogng-flows

feat: add syslogng flow-output validation

Author: csatib02

pkg/sdk/logging/model/syslogng/config/config.go

@@ -56,6 +56,10 @@ type Input struct {
 	SourcePort          int
 }
 
+type outputInfo struct {
+	ref types.NamespacedName
+}
+
 type clusterOutputInfo struct {
 	ref       types.NamespacedName
 	protected bool
@@ -99,7 +103,11 @@ func configRenderer(in Input) (render.Renderer, error) {
 		}
 		destinationDefs = append(destinationDefs, renderClusterOutput(co, in.SecretLoaderFactory))
 	}
+	outputRefs := make(map[string]outputInfo, len(in.Outputs))
 	for _, o := range in.Outputs {
+		outputRefs[o.Name] = outputInfo{
+			ref: types.NamespacedName{Namespace: o.Namespace, Name: o.Name},
+		}
 		destinationDefs = append(destinationDefs, renderOutput(o, in.SecretLoaderFactory))
 	}
 
@@ -114,6 +122,9 @@ func configRenderer(in Input) (render.Renderer, error) {
 		if err := validateClusterOutputs(clusterOutputRefs, client.ObjectKeyFromObject(&f).String(), f.Spec.GlobalOutputRefs, f.Kind); err != nil {
 			errs = errors.Append(errs, err)
 		}
+		if err := validateOutputs(outputRefs, client.ObjectKeyFromObject(&f).String(), f.Spec.LocalOutputRefs); err != nil {
+			errs = errors.Append(errs, err)
+		}
 		logDefs = append(logDefs, renderFlow(in.Name, clusterOutputRefs, sourceName, keyDelim(in.SyslogNGSpec.JSONKeyDelimiter), f, in.SecretLoaderFactory))
 	}
 

pkg/sdk/logging/model/syslogng/config/flow.go

@@ -35,6 +35,15 @@ const (
 	syslogNGFlowKind = "SyslogNGFlow"
 )
 
+func validateOutputs(outputRefs map[string]outputInfo, flow string, localOutputRefs []string) error {
+	return seqs.SeededReduce(seqs.FromSlice(localOutputRefs), nil, func(err error, ref string) error {
+		if _, ok := outputRefs[ref]; !ok {
+			return errors.Append(err, errors.Errorf("output reference %s for flow %s cannot be found", ref, flow))
+		}
+		return err
+	})
+}
+
 func validateClusterOutputs(clusterOutputRefs map[string]clusterOutputInfo, flow string, globalOutputRefs []string, flowKind string) error {
 	return seqs.SeededReduce(seqs.FromSlice(globalOutputRefs), nil, func(err error, ref string) error {
 		if _, ok := clusterOutputRefs[ref]; !ok {