Skip to content

Commit 6469492

Browse files
authored
Merge pull request #133 from sivchari/fix-conflicting-linter-doc
fix documetation about conflictingmarkers
2 parents 47bfeef + 20c428d commit 6469492

File tree

2 files changed

+20
-25
lines changed

2 files changed

+20
-25
lines changed

docs/linters.md

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -96,21 +96,16 @@ Each conflict set must specify:
9696
lintersConfig:
9797
conflictingmarkers:
9898
conflicts:
99-
- name: "optional_vs_required"
100-
sets:
101-
- ["optional", "+kubebuilder:validation:Optional", "+k8s:validation:optional"]
102-
- ["required", "+kubebuilder:validation:Required", "+k8s:validation:required"]
103-
description: "A field cannot be both optional and required"
10499
- name: "default_vs_required"
105100
sets:
106-
- ["default", "+kubebuilder:default"]
107-
- ["required", "+kubebuilder:validation:Required", "+k8s:validation:required"]
101+
- ["default", "kubebuilder:default"]
102+
- ["required", "kubebuilder:validation:Required", "k8s:required"]
108103
description: "A field with a default value cannot be required"
109104
- name: "three_way_conflict"
110105
sets:
111-
- ["marker5", "marker6"]
112-
- ["marker7", "marker8"]
113-
- ["marker9", "marker10"]
106+
- ["custom:marker1", "custom:marker2"]
107+
- ["custom:marker3", "custom:marker4"]
108+
- ["custom:marker5", "custom:marker6"]
114109
description: "Three-way conflict between marker sets"
115110
```
116111

pkg/analysis/conflictingmarkers/doc.go

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -32,21 +32,21 @@ Each conflict set must specify:
3232
3333
Example configuration:
3434
```yaml
35-
lintersConfig:
36-
37-
conflictingmarkers:
38-
conflicts:
39-
- name: "optional_vs_required"
40-
sets:
41-
- ["optional", "+kubebuilder:validation:Optional", "+k8s:validation:optional"]
42-
- ["required", "+kubebuilder:validation:Required", "+k8s:validation:required"]
43-
description: "A field cannot be both optional and required"
44-
- name: "my_custom_conflict"
45-
sets:
46-
- ["custom:marker1", "custom:marker2"]
47-
- ["custom:marker3", "custom:marker4"]
48-
- ["custom:marker5", "custom:marker6"]
49-
description: "These markers define different storage backends that cannot be used simultaneously"
35+
36+
lintersConfig:
37+
conflictingmarkers:
38+
conflicts:
39+
- name: "default_vs_required"
40+
sets:
41+
- ["default", "kubebuilder:default"]
42+
- ["required", "kubebuilder:validation:Required", "k8s:required"]
43+
description: "A field with a default value cannot be required"
44+
- name: "three_way_conflict"
45+
sets:
46+
- ["custom:marker1", "custom:marker2"]
47+
- ["custom:marker3", "custom:marker4"]
48+
- ["custom:marker5", "custom:marker6"]
49+
description: "Three-way conflict between marker sets"
5050
5151
```
5252

0 commit comments

Comments
 (0)