🌱 fix (ci): fix lint issue: shadow: declaration of pluginCfg shadows declaration (#4725)

fix (ci): fix lint issue: shadow: declaration of pluginCfg shadows declaration

Fix plugin config test by resetting struct to avoid value reuse

Avoids test contamination caused by shared PluginConfig variable
by explicitly resetting it before decoding in each test case.
Also resolves shadowing linter errors reported by golangci-lint.

Author: camilamacedo86

pkg/config/v3/config_test.go

@@ -405,22 +405,20 @@ var _ = Describe("Cfg", func() {
 		})
 
 		It("DecodePluginConfig should fail for no plugin config object", func() {
-			var pluginCfg PluginConfig
 			err := c0.DecodePluginConfig(key, &pluginCfg)
 			Expect(err).To(HaveOccurred())
 			Expect(errors.As(err, &config.PluginKeyNotFoundError{})).To(BeTrue())
 		})
 
 		It("DecodePluginConfig should fail to retrieve data from a non-existent plugin", func() {
-			var pluginCfg PluginConfig
 			err := c1.DecodePluginConfig("plugin-y", &pluginCfg)
 			Expect(err).To(HaveOccurred())
 			Expect(errors.As(err, &config.PluginKeyNotFoundError{})).To(BeTrue())
 		})
 
 		DescribeTable("DecodePluginConfig should retrieve the plugin data correctly",
 			func(getCfg func() Cfg, expected func() PluginConfig) {
-				var pluginCfg PluginConfig
+				pluginCfg = PluginConfig{} // reset to not reuse values
 				Expect(getCfg().DecodePluginConfig(key, &pluginCfg)).To(Succeed())
 				Expect(pluginCfg).To(Equal(expected()))
 			},