Merge pull request #4703 from kersten/chore/store-tests-init-vars

🌱  (chore): refactor unit tests to isolate mutable state with BeforeEach for pkg/config/store

Author: k8s-ci-robot

pkg/config/store/errors_test.go

@@ -31,10 +31,15 @@ func TestConfigStore(t *testing.T) {
 
 var _ = Describe("LoadError", func() {
 	var (
-		wrapped = fmt.Errorf("error message")
-		err     = LoadError{Err: wrapped}
+		wrapped error
+		err     LoadError
 	)
 
+	BeforeEach(func() {
+		wrapped = fmt.Errorf("error message")
+		err = LoadError{Err: wrapped}
+	})
+
 	Context("Error", func() {
 		It("should return the correct error message", func() {
 			Expect(err.Error()).To(Equal(fmt.Sprintf("unable to load the configuration: %v", wrapped)))
@@ -50,10 +55,15 @@ var _ = Describe("LoadError", func() {
 
 var _ = Describe("SaveError", func() {
 	var (
-		wrapped = fmt.Errorf("error message")
-		err     = SaveError{Err: wrapped}
+		wrapped error
+		err     SaveError
 	)
 
+	BeforeEach(func() {
+		wrapped = fmt.Errorf("error message")
+		err = SaveError{Err: wrapped}
+	})
+
 	Context("Error", func() {
 		It("should return the correct error message", func() {
 			Expect(err.Error()).To(Equal(fmt.Sprintf("unable to save the configuration: %v", wrapped)))

pkg/config/store/yaml/store_test.go

@@ -62,13 +62,13 @@ layout: ""
 	)
 
 	var (
-		s *yamlStore
-
-		path = DefaultPath + "2"
+		s    *yamlStore
+		path string
 	)
 
 	BeforeEach(func() {
 		s = New(machinery.Filesystem{FS: afero.NewMemMapFs()}).(*yamlStore)
+		path = DefaultPath + "2"
 	})
 
 	Context("New", func() {