feat: helm v2-alpha: refactorize values basic deployment config cyclomatic complexity to pass linting

Signed-off-by: Robin LIORET <robin.lioret@darylsocialsoftware.com>

Author: robinlioret

pkg/plugins/optional/helm/v2alpha/scaffolds/internal/templates/values_basic.go

@@ -210,15 +210,7 @@ func (f *HelmValuesBasic) addDeploymentConfig(buf *bytes.Buffer) {
 		buf.WriteString("  # Environment variables\n")
 		buf.WriteString("  env:\n")
 		if envYaml, err := yaml.Marshal(env); err == nil {
-			// Indent the YAML properly
-			lines := bytes.Split(envYaml, []byte("\n"))
-			for _, line := range lines {
-				if len(line) > 0 {
-					buf.WriteString("    ")
-					buf.Write(line)
-					buf.WriteString("\n")
-				}
-			}
+			f.IndentYamlProperly(buf, envYaml)
 		} else {
 			buf.WriteString("    []\n")
 		}
@@ -233,14 +225,7 @@ func (f *HelmValuesBasic) addDeploymentConfig(buf *bytes.Buffer) {
 		buf.WriteString("  # Pod-level security settings\n")
 		buf.WriteString("  podSecurityContext:\n")
 		if secYaml, err := yaml.Marshal(podSecCtx); err == nil {
-			lines := bytes.Split(secYaml, []byte("\n"))
-			for _, line := range lines {
-				if len(line) > 0 {
-					buf.WriteString("    ")
-					buf.Write(line)
-					buf.WriteString("\n")
-				}
-			}
+			f.IndentYamlProperly(buf, secYaml)
 		}
 		buf.WriteString("\n")
 	} else {
@@ -252,14 +237,7 @@ func (f *HelmValuesBasic) addDeploymentConfig(buf *bytes.Buffer) {
 		buf.WriteString("  # Container-level security settings\n")
 		buf.WriteString("  securityContext:\n")
 		if secYaml, err := yaml.Marshal(secCtx); err == nil {
-			lines := bytes.Split(secYaml, []byte("\n"))
-			for _, line := range lines {
-				if len(line) > 0 {
-					buf.WriteString("    ")
-					buf.Write(line)
-					buf.WriteString("\n")
-				}
-			}
+			f.IndentYamlProperly(buf, secYaml)
 		}
 		buf.WriteString("\n")
 	} else {
@@ -271,14 +249,7 @@ func (f *HelmValuesBasic) addDeploymentConfig(buf *bytes.Buffer) {
 		buf.WriteString("  # Resource limits and requests\n")
 		buf.WriteString("  resources:\n")
 		if resYaml, err := yaml.Marshal(resources); err == nil {
-			lines := bytes.Split(resYaml, []byte("\n"))
-			for _, line := range lines {
-				if len(line) > 0 {
-					buf.WriteString("    ")
-					buf.Write(line)
-					buf.WriteString("\n")
-				}
-			}
+			f.IndentYamlProperly(buf, resYaml)
 		}
 		buf.WriteString("\n")
 	} else {
@@ -289,14 +260,7 @@ func (f *HelmValuesBasic) addDeploymentConfig(buf *bytes.Buffer) {
 	if affinity, exists := f.DeploymentConfig["podAffinity"]; exists && affinity != nil {
 		buf.WriteString("  affinity:\n")
 		if affYaml, err := yaml.Marshal(affinity); err == nil {
-			lines := bytes.Split(affYaml, []byte("\n"))
-			for _, line := range lines {
-				if len(line) > 0 {
-					buf.WriteString("    ")
-					buf.Write(line)
-					buf.WriteString("\n")
-				}
-			}
+			f.IndentYamlProperly(buf, affYaml)
 		}
 		buf.WriteString("\n")
 	} else {
@@ -308,14 +272,7 @@ func (f *HelmValuesBasic) addDeploymentConfig(buf *bytes.Buffer) {
 	if nodeSelector, exists := f.DeploymentConfig["podNodeSelector"]; exists && nodeSelector != nil {
 		buf.WriteString("  nodeSelector:\n")
 		if nodYaml, err := yaml.Marshal(nodeSelector); err == nil {
-			lines := bytes.Split(nodYaml, []byte("\n"))
-			for _, line := range lines {
-				if len(line) > 0 {
-					buf.WriteString("    ")
-					buf.Write(line)
-					buf.WriteString("\n")
-				}
-			}
+			f.IndentYamlProperly(buf, nodYaml)
 		}
 		buf.WriteString("\n")
 	} else {
@@ -327,14 +284,7 @@ func (f *HelmValuesBasic) addDeploymentConfig(buf *bytes.Buffer) {
 	if tolerations, exists := f.DeploymentConfig["podTolerations"]; exists && tolerations != nil {
 		buf.WriteString("  tolerations:\n")
 		if tolYaml, err := yaml.Marshal(tolerations); err == nil {
-			lines := bytes.Split(tolYaml, []byte("\n"))
-			for _, line := range lines {
-				if len(line) > 0 {
-					buf.WriteString("    ")
-					buf.Write(line)
-					buf.WriteString("\n")
-				}
-			}
+			f.IndentYamlProperly(buf, tolYaml)
 		}
 		buf.WriteString("\n")
 	} else {
@@ -343,6 +293,17 @@ func (f *HelmValuesBasic) addDeploymentConfig(buf *bytes.Buffer) {
 	}
 }
 
+func (f *HelmValuesBasic) IndentYamlProperly(buf *bytes.Buffer, envYaml []byte) {
+	lines := bytes.Split(envYaml, []byte("\n"))
+	for _, line := range lines {
+		if len(line) > 0 {
+			buf.WriteString("    ")
+			buf.Write(line)
+			buf.WriteString("\n")
+		}
+	}
+}
+
 // addDefaultDeploymentSections adds default sections when no deployment config is available
 func (f *HelmValuesBasic) addDefaultDeploymentSections(buf *bytes.Buffer) {
 	buf.WriteString("  # Environment variables\n")