Merge pull request #4774 from Kuzuri247/update

k8s-ci-robot · web-flow · commit 9932c89b631b · 2025-04-12T00:36:41.000-07:00
🌱 (Follow up of #4752 )Remove 'install-mode: goinstall' from the GitHub Action. This was added temporarily to allow us to move forward. (removed this temporary addition before any release.)
diff --git a/.github/workflows/lint-sample.yml b/.github/workflows/lint-sample.yml
@@ -38,7 +38,6 @@ jobs:
       - name: Run linter
         uses: golangci/golangci-lint-action@v7
         with:
-          install-mode: goinstall
           version: v2.0.2
           working-directory: ${{ matrix.folder }}
           args: --config .golangci.yml ./...
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -26,7 +26,6 @@ jobs:
       - name: Run linter
         uses: golangci/golangci-lint-action@v7
         with:
-          install-mode: goinstall 
           version: v2.0.2
 
   yamllint:
diff --git a/docs/book/src/cronjob-tutorial/testdata/project/.github/workflows/lint.yml b/docs/book/src/cronjob-tutorial/testdata/project/.github/workflows/lint.yml
@@ -20,5 +20,4 @@ jobs:
       - name: Run linter
         uses: golangci/golangci-lint-action@v7
         with:
-          install-mode: goinstall
           version: v2.0.2
diff --git a/docs/book/src/getting-started/testdata/project/.github/workflows/lint.yml b/docs/book/src/getting-started/testdata/project/.github/workflows/lint.yml
@@ -20,5 +20,4 @@ jobs:
       - name: Run linter
         uses: golangci/golangci-lint-action@v7
         with:
-          install-mode: goinstall
           version: v2.0.2
diff --git a/docs/book/src/multiversion-tutorial/testdata/project/.github/workflows/lint.yml b/docs/book/src/multiversion-tutorial/testdata/project/.github/workflows/lint.yml
@@ -20,5 +20,4 @@ jobs:
       - name: Run linter
         uses: golangci/golangci-lint-action@v7
         with:
-          install-mode: goinstall
           version: v2.0.2
diff --git a/pkg/plugins/golang/v4/scaffolds/internal/templates/github/lint.go b/pkg/plugins/golang/v4/scaffolds/internal/templates/github/lint.go
@@ -68,6 +68,5 @@ jobs:
       - name: Run linter
         uses: golangci/golangci-lint-action@v7
         with:
-          install-mode: goinstall
           version: {{ .GolangciLintVersion }}
 `
diff --git a/testdata/project-v4-multigroup/.github/workflows/lint.yml b/testdata/project-v4-multigroup/.github/workflows/lint.yml
@@ -20,5 +20,4 @@ jobs:
       - name: Run linter
         uses: golangci/golangci-lint-action@v7
         with:
-          install-mode: goinstall
           version: v2.0.2
diff --git a/testdata/project-v4-with-plugins/.github/workflows/lint.yml b/testdata/project-v4-with-plugins/.github/workflows/lint.yml
@@ -20,5 +20,4 @@ jobs:
       - name: Run linter
         uses: golangci/golangci-lint-action@v7
         with:
-          install-mode: goinstall
           version: v2.0.2
diff --git a/testdata/project-v4/.github/workflows/lint.yml b/testdata/project-v4/.github/workflows/lint.yml
@@ -20,5 +20,4 @@ jobs:
       - name: Run linter
         uses: golangci/golangci-lint-action@v7
         with:
-          install-mode: goinstall
           version: v2.0.2

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,5 @@ jobs:`
`68`	`68`	`- name: Run linter`
`69`	`69`	`uses: golangci/golangci-lint-action@v7`
`70`	`70`	`with:`
`71`		`- install-mode: goinstall`
`72`	`71`	`version: {{ .GolangciLintVersion }}`
`73`	`72`	`