Skip to content

Commit 0ea2f09

Browse files
add clarification comments on some implementation details, link documentation
1 parent dd0222e commit 0ea2f09

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

pkg/addons/helm.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import (
2525
"k8s.io/minikube/pkg/minikube/vmpath"
2626
)
2727

28-
// runs a helm install based on the contents of chart *assets.HelmChart
28+
// runs a helm install within the minikube vm or container based on the contents of chart *assets.HelmChart
2929
func installHelmChart (ctx context.Context, chart *assets.HelmChart) *exec.Cmd {
3030
args := []string{
3131
fmt.Sprintf("KUBECONFIG=%s", path.Join(vmpath.GuestPersistentDir, "kubeconfig")),
@@ -80,6 +80,7 @@ func helmInstallBinary(addon *assets.Addon, runner command.Runner) error {
8080

8181
installCmd := fmt.Sprint("curl -fsSL -o get_helm.sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 && chmod 700 get_helm.sh && ./get_helm.sh")
8282
_, err = runner.RunCmd(exec.Command("sudo", "bash", "-c", installCmd))
83+
// we copy the binary from /usr/local/bin to /usr/bin because /usr/local/bin is not in PATH in both iso and kicbase
8384
_, err = runner.RunCmd(exec.Command("sudo", "mv", "/usr/local/bin/helm", "/usr/bin/helm"))
8485
if err != nil {
8586
return errors.Wrap(err, "installing helm")

site/content/en/docs/contrib/addons.en.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,8 @@ The boolean value on the last line is whether the addon should be enabled by def
9393

9494
To see other examples, see the [addons commit history](https://github.com/kubernetes/minikube/commits/master/deploy/addons) for other recent examples.
9595

96+
To add a helm based addon please check out [Helm Based Addons](/docs/contrib/addons)
97+
9698
## "addons open" support
9799

98100
If your addon contains a NodePort Service, please add the `kubernetes.io/minikube-addons-endpoint: <addon name>` label, which is used by the `minikube addons open` command:

0 commit comments

Comments
 (0)