addressed TestGetStoragev1class unit test failure comments

bobsira · bobsira · commit 0f64f31b8846 · 2025-10-16T16:25:28.000+01:00
diff --git a/pkg/minikube/storageclass/storageclass_test.go b/pkg/minikube/storageclass/storageclass_test.go
@@ -252,11 +252,8 @@ func TestGetStoragev1(t *testing.T) {
 }
 
 func setK8SConfig(t *testing.T, config, kubeconfigPath string) error {
-	if err := os.MkdirAll(filepath.Dir(kubeconfigPath), 0o755); err != nil {
-		return fmt.Errorf("failed to create kubeconfig directory: %w", err)
-	}
 	if err := os.WriteFile(kubeconfigPath, []byte(config), 0o644); err != nil {
-		return fmt.Errorf("unexpected error when writing to %v: %w", kubeconfigPath, err)
+		t.Fatalf("unexpected error when writing to %v: %v", kubeconfigPath, err)
 	}
 	t.Setenv("KUBECONFIG", kubeconfigPath)
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -252,11 +252,8 @@ func TestGetStoragev1(t *testing.T) {`
`252`	`252`	`}`
`253`	`253`
`254`	`254`	`func setK8SConfig(t *testing.T, config, kubeconfigPath string) error {`
`255`		`- if err := os.MkdirAll(filepath.Dir(kubeconfigPath), 0o755); err != nil {`
`256`		`- return fmt.Errorf("failed to create kubeconfig directory: %w", err)`
`257`		`- }`
`258`	`255`	`if err := os.WriteFile(kubeconfigPath, []byte(config), 0o644); err != nil {`
`259`		`- return fmt.Errorf("unexpected error when writing to %v: %w", kubeconfigPath, err)`
	`256`	`+ t.Fatalf("unexpected error when writing to %v: %v", kubeconfigPath, err)`
`260`	`257`	`}`
`261`	`258`	`t.Setenv("KUBECONFIG", kubeconfigPath)`
`262`	`259`	`return nil`