Skip to content

Commit 3d9e4a2

Browse files
add description to helmcommand and rename helminstall to helminstallbinary
1 parent 1fe32a0 commit 3d9e4a2

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

pkg/addons/addons.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ func enableOrDisableAddonInternal(cc *config.ClusterConfig, addon *assets.Addon,
451451
}
452452

453453
if addon.HelmChart != nil {
454-
err := helmInstall(addon,runner)
454+
err := helmInstallBinary(addon,runner)
455455
if err != nil {
456456
return err
457457
}

pkg/addons/helm.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import (
2626
"k8s.io/minikube/pkg/minikube/vmpath"
2727
)
2828

29+
// runs a helm install/uninstall based on the contents of chart *assets.HelmChart and enable
2930
func helmCommand(ctx context.Context, chart *assets.HelmChart, enable bool) *exec.Cmd {
3031
var args []string
3132

@@ -60,7 +61,7 @@ func helmCommand(ctx context.Context, chart *assets.HelmChart, enable bool) *exe
6061
return exec.CommandContext(ctx, "sudo", args...)
6162
}
6263

63-
func helmInstall(addon *assets.Addon, runner command.Runner) error {
64+
func helmInstallBinary(addon *assets.Addon, runner command.Runner) error {
6465
_, err := runner.RunCmd(exec.Command("test", "-f", "/usr/bin/helm"))
6566
if err != nil {
6667
// If not, install it

0 commit comments

Comments
 (0)