Skip to content

Commit 8e14ec5

Browse files
authored
Merge pull request #21671 from nirs/hack-build-iso
hack: Fix review comment for failed iso build
2 parents 6352d87 + 6736ba9 commit 8e14ec5

File tree

1 file changed

+14
-16
lines changed

1 file changed

+14
-16
lines changed

hack/jenkins/build_iso.sh

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -66,22 +66,20 @@ else
6666
fi
6767

6868
if ! make release-iso 2>&1 | tee iso-logs.txt; then
69-
# Exit of `make` (PIPESTATUS[0]); fallback to 1 if unavailable
70-
ec=${PIPESTATUS[0]:-1}
71-
72-
# Only comment on non-release; default release=false if unset
73-
if [[ ${release:-false} != "true" ]]; then
74-
body="$(cat <<'EOF'
75-
Hi ${ghprbPullAuthorLoginMention}, building a new ISO failed for Commit ${ghprbActualCommit}
76-
See the logs at:
77-
https://storage.cloud.google.com/minikube-builds/logs/${ghprbPullId}/${ghprbActualCommit::7}/iso_build.txt
78-
EOF
79-
"
80-
81-
gh pr comment "${ghprbPullId}" --body "$body"
82-
83-
fi
84-
exit "$ec"
69+
# Exit of `make` (PIPESTATUS[0]); fallback to 1 if unavailable
70+
ec=${PIPESTATUS[0]:-1}
71+
72+
# Only comment on non-release; default release=false if unset
73+
if [[ ${release:-false} != "true" ]]; then
74+
body=$(cat << EOF
75+
Hi ${ghprbPullAuthorLoginMention}, building a new ISO failed for Commit ${ghprbActualCommit}
76+
See the logs at:
77+
https://storage.cloud.google.com/minikube-builds/logs/${ghprbPullId}/${ghprbActualCommit::7}/iso_build.txt
78+
EOF
79+
)
80+
gh pr comment "${ghprbPullId}" --body "$body"
81+
fi
82+
exit "$ec"
8583
fi
8684

8785
git config user.name "minikube-bot"

0 commit comments

Comments
 (0)