download hyperkit from 1.37.0 and warn user this is last release

Author: medyagh

cmd/minikube/cmd/start.go

@@ -535,10 +535,7 @@ func warnAboutMultiNodeCNI() {
 }
 
 func updateDriver(driverName string) {
-	v, err := version.GetSemverVersion()
-	if err != nil {
-		out.WarningT("Error parsing minikube version: {{.error}}", out.V{"error": err})
-	} else if err := auxdriver.InstallOrUpdate(driverName, localpath.MakeMiniPath("bin"), v, viper.GetBool(flags.Interactive), viper.GetBool(autoUpdate)); err != nil {
+	if err := auxdriver.InstallOrUpdate(driverName, localpath.MakeMiniPath("bin"), viper.GetBool(flags.Interactive), viper.GetBool(autoUpdate)); err != nil {
 		if errors.Is(err, auxdriver.ErrAuxDriverVersionCommandFailed) {
 			exit.Error(reason.DrvAuxNotHealthy, "Aux driver "+driverName, err)
 		}

pkg/minikube/driver/auxdriver/install.go

@@ -53,10 +53,18 @@ var ErrAuxDriverVersionCommandFailed error
 var ErrAuxDriverVersionNotinPath error
 
 // InstallOrUpdate downloads driver if it is not present, or updates it if there's a newer version
-func InstallOrUpdate(name string, directory string, v semver.Version, interactive bool, autoUpdate bool) error {
+// this is currently only used for hyperkit driver on macOS
+func InstallOrUpdate(name string, directory string, interactive bool, autoUpdate bool) error {
 	if name != driver.HyperKit {
 		return nil
 	}
+	// v1.37.0 was the last release that we built hyperkit driver https://github.com/kubernetes/minikube/issues/21940
+	// this will be used till we completely remove hyperkit driver support
+	v, err := semver.Make("1.37.0")
+	out.WarningT("Hyperkit driver will be removed in the next minikube release, we have other drivers that work on macOS such as docker or qemu, vfkit. Please consider switching to one of them. For more information, please visit: https://minikube.sigs.k8s.io/docs/drivers/hyperkit/")
+	if err != nil {
+		return errors.Wrap(err, "can't parse version")
+	}
 
 	executable := fmt.Sprintf("docker-machine-driver-%s", name)
 

test/integration/driver_install_or_update_test.go

@@ -83,7 +83,7 @@ func TestHyperKitDriverInstallOrUpdate(t *testing.T) {
 			t.Skipf("password required to execute 'sudo', skipping remaining test")
 		}
 
-		err = auxdriver.InstallOrUpdate("hyperkit", dir, newerVersion, false, true)
+		err = auxdriver.InstallOrUpdate("hyperkit", dir, false, true)
 		if err != nil {
 			t.Fatalf("Failed to update driver to %v. test: %s, got: %v", newerVersion, tc.name, err)
 		}