refactor helm functions - fix install and tests

Author: volatilemolotov

pkg/addons/helm.go

@@ -29,11 +29,24 @@ import (
 func installHelmChart (ctx context.Context, chart *assets.HelmChart) *exec.Cmd {
 	args := []string{
 		fmt.Sprintf("KUBECONFIG=%s", path.Join(vmpath.GuestPersistentDir, "kubeconfig")),
-		"helm", "uninstall", chart.Name,
-			}
+		"helm", "upgrade", "--install", chart.Name, chart.Repo, "--create-namespace",
+	}
 			if chart.Namespace != "" {
 			args = append(args, "--namespace", chart.Namespace)
 		}
+
+			if chart.Values != nil {
+				for _, value := range chart.Values {
+					args = append(args, "--set", value)
+					}
+				}
+
+			if chart.ValueFiles != nil {
+				for _, value := range chart.ValueFiles {
+					args = append(args, "--values", value)
+					}
+				}
+				
 		return exec.CommandContext(ctx, "sudo", args...)
 	}
 

pkg/addons/helm_test.go

@@ -66,7 +66,7 @@ func TestHelmCommand(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(test.description, func(t *testing.T) {
-			command := helmCommand(context.Background(), test.chart, test.enable )
+			command := helmUninstallOrInstall(context.Background(), test.chart, test.enable )
 			actual := strings.Join(command.Args, " ")
 			if actual != test.expected {
 				t.Errorf("helm command mismatch:\nexpected: %s\nactual:   %s", test.expected, actual)