[fix] instancing validation flag name & add it to render-validation-all.

Author: vmarcella

crates/lambda-rs/Cargo.toml

@@ -58,6 +58,7 @@ render-validation-strict = [
 render-validation-all = [
   "render-validation-strict",
   "render-validation-device",
+  "render-validation-instancing",
 ]
 
 # Granular feature flags
@@ -73,7 +74,7 @@ render-validation-stencil = []
 render-validation-pass-compat = []
 render-validation-device = []
 render-validation-encoder = []
-render-instancing-validation = []
+render-validation-instancing = []
 
 
 # ---------------------------- PLATFORM DEPENDENCIES ---------------------------

crates/lambda-rs/src/render/mod.rs

@@ -621,17 +621,13 @@ impl RenderContext {
   {
     Self::apply_viewport(pass, &initial_viewport);
 
-    #[cfg(any(
-      debug_assertions,
-      feature = "render-validation-encoder",
-      feature = "render-instancing-validation",
-    ))]
+    #[cfg(any(debug_assertions, feature = "render-validation-encoder",))]
     let mut current_pipeline: Option<usize> = None;
 
     #[cfg(any(debug_assertions, feature = "render-validation-encoder",))]
     let mut bound_index_buffer: Option<(usize, u32)> = None;
 
-    #[cfg(any(debug_assertions, feature = "render-instancing-validation",))]
+    #[cfg(any(debug_assertions, feature = "render-validation-instancing",))]
     let mut bound_vertex_slots: HashSet<u32> = HashSet::new();
 
     // De-duplicate advisories within this pass
@@ -882,11 +878,7 @@ impl RenderContext {
           vertices,
           instances,
         } => {
-          #[cfg(any(
-            debug_assertions,
-            feature = "render-validation-encoder",
-            feature = "render-instancing-validation",
-          ))]
+          #[cfg(any(debug_assertions, feature = "render-validation-encoder",))]
           {
             if current_pipeline.is_none() {
               return Err(RenderError::Configuration(
@@ -898,7 +890,7 @@ impl RenderContext {
 
           #[cfg(any(
             debug_assertions,
-            feature = "render-instancing-validation",
+            feature = "render-validation-instancing",
           ))]
           {
             let pipeline_index = current_pipeline
@@ -920,7 +912,7 @@ impl RenderContext {
           }
           #[cfg(any(
             debug_assertions,
-            feature = "render-instancing-validation",
+            feature = "render-validation-instancing",
           ))]
           {
             if instances.start == instances.end {
@@ -976,21 +968,7 @@ impl RenderContext {
           }
           #[cfg(any(
             debug_assertions,
-            feature = "render-validation-encoder",
-            feature = "render-instancing-validation",
-          ))]
-          {
-            if current_pipeline.is_none() {
-              return Err(RenderError::Configuration(
-                "DrawIndexed command encountered before any pipeline was set in this render pass"
-                  .to_string(),
-              ));
-            }
-          }
-
-          #[cfg(any(
-            debug_assertions,
-            feature = "render-instancing-validation",
+            feature = "render-validation-instancing",
           ))]
           {
             let pipeline_index = current_pipeline
@@ -1012,7 +990,7 @@ impl RenderContext {
           }
           #[cfg(any(
             debug_assertions,
-            feature = "render-instancing-validation",
+            feature = "render-validation-instancing",
           ))]
           {
             if instances.start == instances.end {

docs/features.md

@@ -3,13 +3,13 @@ title: "Cargo Features Overview"
 document_id: "features-2025-11-17"
 status: "living"
 created: "2025-11-17T23:59:00Z"
-last_updated: "2025-11-25T00:00:00Z"
-version: "0.1.1"
+last_updated: "2025-11-25T02:20:00Z"
+version: "0.1.3"
 engine_workspace_version: "2023.1.30"
 wgpu_version: "26.0.1"
 shader_backend_default: "naga"
 winit_version: "0.29.10"
-repo_commit: "b1f0509d245065823dff2721f97e16c0215acc4f"
+repo_commit: "c8f727f3774029135ed1f7a7224288faf7b9e442"
 owners: ["lambda-sh"]
 reviewers: ["engine", "rendering"]
 tags: ["guide", "features", "validation", "cargo"]
@@ -44,9 +44,9 @@ This document enumerates the primary Cargo features exposed by the workspace rel
 ## Render Validation
 
 Umbrella features (crate: `lambda-rs`)
-- `render-validation`: enables common builder/pipeline validation logs (MSAA counts, depth clear advisories, stencil format upgrades).
-- `render-validation-strict`: includes `render-validation` and enables per-draw SetPipeline-time compatibility checks.
-- `render-validation-all`: superset of `render-validation-strict` and enables device-probing advisories.
+- `render-validation`: enables common builder/pipeline validation logs (MSAA counts, depth clear advisories, stencil format upgrades) by composing granular validation features.
+- `render-validation-strict`: includes `render-validation` and enables per-draw SetPipeline-time compatibility checks by composing additional granular encoder features.
+- `render-validation-all`: superset of `render-validation-strict` and enables device-probing advisories and instancing validation. This umbrella includes all granular render-validation flags, including `render-validation-instancing`.
 
 Granular features (crate: `lambda-rs`)
 - `render-validation-msaa`: validates/logs MSAA sample counts; logs pass/pipeline sample mismatches. Behavior:
@@ -57,7 +57,7 @@ Granular features (crate: `lambda-rs`)
 - `render-validation-pass-compat`: SetPipeline-time errors when color targets or depth/stencil expectations do not match the active pass.
 - `render-validation-device`: device/format probing advisories (if available via the platform layer).
 - `render-validation-encoder`: additional per-draw/encoder-time checks; highest runtime cost.
-- `render-instancing-validation`: instance-range and per-instance buffer binding validation for `RenderCommand::Draw` and `RenderCommand::DrawIndexed`. Behavior:
+- `render-validation-instancing`: instance-range and per-instance buffer binding validation for `RenderCommand::Draw` and `RenderCommand::DrawIndexed`. Behavior:
   - Validates that `instances.start <= instances.end` and treats `start == end` as a no-op (draw is skipped).
   - Ensures that all vertex buffer slots marked as per-instance on the active pipeline have been bound in the current render pass.
   - Adds per-draw checks proportional to the number of instanced draws and per-instance slots; SHOULD be enabled only when diagnosing instancing issues.
@@ -76,9 +76,13 @@ Usage examples
   - `cargo build -p lambda-rs --features render-validation`
 - Enable strict compatibility checks in release:
   - `cargo run -p lambda-rs --features render-validation-strict`
+- Enable all validations, including device advisories and instancing validation, in release:
+  - `cargo test -p lambda-rs --features render-validation-all`
 - Enable only MSAA validation in release:
   - `cargo test -p lambda-rs --features render-validation-msaa`
 
 ## Changelog
+- 0.1.3 (2025-11-25): Rename the instancing validation feature to `render-validation-instancing`, clarify umbrella composition, and update metadata.
+- 0.1.2 (2025-11-25): Clarify umbrella versus granular validation features, record that `render-validation-all` includes `render-instancing-validation`, and update metadata.
 - 0.1.1 (2025-11-25): Document `render-instancing-validation` behavior and update metadata.
 - 0.1.0 (2025-11-17): Initial document introducing validation features and behavior by build type.

docs/specs/instanced-rendering.md

@@ -3,13 +3,13 @@ title: "Instanced Rendering"
 document_id: "instanced-rendering-2025-11-23"
 status: "draft"
 created: "2025-11-23T00:00:00Z"
-last_updated: "2025-11-25T01:00:00Z"
-version: "0.1.3"
+last_updated: "2025-11-25T02:20:00Z"
+version: "0.1.5"
 engine_workspace_version: "2023.1.30"
 wgpu_version: "26.0.1"
 shader_backend_default: "naga"
 winit_version: "0.29.10"
-repo_commit: "7f8375d73a0dbca5eb143dda38e8e1600f62683c"
+repo_commit: "c8f727f3774029135ed1f7a7224288faf7b9e442"
 owners: ["lambda-sh"]
 reviewers: ["engine", "rendering"]
 tags: ["spec", "rendering", "instancing", "vertex-input"]
@@ -168,7 +168,7 @@ App Code
   - The `lambda-rs` crate MUST treat `instances = 0..1` as the default
         single-instance behavior used by existing rendering paths.
   - Feature flags (`lambda-rs`)
-    - `render-instancing-validation`
+    - `render-validation-instancing`
       - Owning crate: `lambda-rs`.
       - Default: disabled in release builds; MAY be enabled in debug builds or
         by opt-in.
@@ -211,15 +211,19 @@ App Code
     and instance) before issuing `Draw` or `DrawIndexed` commands that rely on
     those slots.
 - Validation behavior
-  - When `render-instancing-validation` and `render-validation-encoder` are
-    enabled, the `lambda-rs` crate SHOULD:
+  - When `render-validation-instancing` is enabled (or when `debug_assertions`
+    are active), the `lambda-rs` crate SHOULD:
     - Verify that all buffer slots used by per-instance attributes are bound
       before a draw that uses those attributes.
     - Emit a clear error when a draw is issued with an `instances` range whose
       upper bound exceeds expectations for the instance buffer size, when this
       information is available.
     - Check that `instances.start <= instances.end` and treat negative-length
       ranges as configuration errors.
+  - Umbrella features such as `render-validation-all` MAY include
+    `render-validation-instancing` for convenience, but code and tests MUST
+    gate instancing behavior on the granular `render-validation-instancing`
+    feature (plus `debug_assertions`), not on umbrella feature names.
 
 ### Validation and Errors
 
@@ -233,7 +237,7 @@ App Code
   - `BindVertexBuffer` MUST reference a buffer created with `BufferType::Vertex`
     and a slot index that is less than the number of vertex buffer layouts
     declared on the pipeline.
-  - When `render-instancing-validation` is enabled, the `lambda-rs` crate SHOULD:
+  - When `render-validation-instancing` is enabled, the `lambda-rs` crate SHOULD:
     - Verify that the set of bound buffers covers all pipeline slots that
       declare per-instance attributes before a draw is issued.
     - Log an error if a draw is issued with a per-instance attribute whose slot
@@ -369,6 +373,8 @@ relevant code and tests, for example in the pull request description.
 
 ## Changelog
 
+- 2025-11-25 (v0.1.5) — Rename the granular instancing validation feature to `render-validation-instancing`, clarify naming in feature documentation, and update metadata.
+- 2025-11-25 (v0.1.4) — Clarify that instancing validation is gated by the granular `render-instancing-validation` feature (and `debug_assertions`) and may be included in umbrella features such as `render-validation-all`; update metadata.
 - 2025-11-25 (v0.1.3) — Mark existing draw paths as compatible with `instances = 0..1`, record the addition of an instanced rendering example, and update metadata.
 - 2025-11-25 (v0.1.2) — Update terminology to reference crates by name, remove per-file implementation locations from the Requirements Checklist, and mark instancing validation features as implemented in `lambda-rs`.
 - 2025-11-24 (v0.1.1) — Mark initial instancing layout and step mode support as implemented in the Requirements Checklist; metadata updated.

docs/tutorials/instanced-quads.md

@@ -3,13 +3,13 @@ title: "Instanced Rendering: Grid of Colored Quads"
 document_id: "instanced-quads-tutorial-2025-11-25"
 status: "draft"
 created: "2025-11-25T00:00:00Z"
-last_updated: "2025-11-25T00:00:00Z"
-version: "0.1.0"
+last_updated: "2025-11-25T02:20:00Z"
+version: "0.1.1"
 engine_workspace_version: "2023.1.30"
 wgpu_version: "26.0.1"
 shader_backend_default: "naga"
 winit_version: "0.29.10"
-repo_commit: "2ff0a581af014a754e982881193c36f47e685602"
+repo_commit: "c8f727f3774029135ed1f7a7224288faf7b9e442"
 owners: ["lambda-sh"]
 reviewers: ["engine", "rendering"]
 tags: ["tutorial", "graphics", "instancing", "vertex-buffers", "rust", "wgpu"]
@@ -479,7 +479,7 @@ The commands bind both vertex buffers and the index buffer before issuing `DrawI
 
 - Vertex attribute locations in the shaders MUST match the `VertexAttribute` configuration for both the per-vertex and per-instance buffers.
 - The instance buffer MUST be bound on the same slot that `with_instance_buffer` uses; binding a different slot will lead to incorrect or undefined attribute data during rendering.
-- Instance ranges for `DrawIndexed` MUST remain within the logical count of instances created for the instance buffer; validation features such as `render-instancing-validation` SHOULD be enabled when developing new instanced render paths.
+- Instance ranges for `DrawIndexed` MUST remain within the logical count of instances created for the instance buffer; validation features such as `render-validation-instancing` SHOULD be enabled when developing new instanced render paths.
 - Per-instance data MAY be updated each frame to animate offsets or colors; static data is sufficient for verifying buffer layouts and instance ranges.
 
 ## Conclusion <a name="conclusion"></a>
@@ -493,8 +493,9 @@ This tutorial demonstrates how the `lambda-rs` crate uses per-vertex and per-ins
 - Introduce a uniform buffer that applies a global transform to all instances and combine it with per-instance offsets.
 - Extend the shaders to include per-instance scale or rotation and add fields to `InstanceData` to drive those transforms.
 - Add a second instanced draw call that uses the same geometry but a different instance buffer to render a second grid with an alternate color pattern.
-- Experiment with validation features, such as `render-instancing-validation`, by intentionally omitting the instance buffer binding and observing how configuration errors are reported.
+- Experiment with validation features, such as `render-validation-instancing`, by intentionally omitting the instance buffer binding and observing how configuration errors are reported.
 
 ## Changelog <a name="changelog"></a>
 
+- 2025-11-25 (v0.1.1) — Align feature naming with `render-validation-instancing` and update metadata.
 - 2025-11-25 (v0.1.0) — Initial instanced quads tutorial describing per-vertex and per-instance buffers and the `instanced_quads` example.