[add] platform conversions to depth/stencil ops directly.

Author: vmarcella

crates/lambda-rs/src/render/encoder.rs

@@ -41,13 +41,7 @@ use super::{
   command::IndexFormat,
   pipeline,
   pipeline::RenderPipeline,
-  render_pass::{
-    ColorLoadOp,
-    DepthLoadOp,
-    RenderPass,
-    StencilLoadOp,
-    StoreOp,
-  },
+  render_pass::RenderPass,
   texture::DepthTexture,
   validation,
   viewport::Viewport,
@@ -214,54 +208,16 @@ impl<'pass> RenderPassEncoder<'pass> {
     let mut rp_builder = platform::render_pass::RenderPassBuilder::new();
 
     // Map color operations from the high-level RenderPass
-    let color_ops = pass.color_operations();
-    rp_builder = match color_ops.load {
-      ColorLoadOp::Load => {
-        rp_builder.with_color_load_op(platform::render_pass::ColorLoadOp::Load)
-      }
-      ColorLoadOp::Clear(color) => rp_builder
-        .with_color_load_op(platform::render_pass::ColorLoadOp::Clear(color)),
-    };
-    rp_builder = match color_ops.store {
-      StoreOp::Store => {
-        rp_builder.with_store_op(platform::render_pass::StoreOp::Store)
-      }
-      StoreOp::Discard => {
-        rp_builder.with_store_op(platform::render_pass::StoreOp::Discard)
-      }
-    };
-
-    // Map depth operations from the high-level RenderPass
-    let platform_depth_ops = pass.depth_operations().map(|dop| {
-      platform::render_pass::DepthOperations {
-        load: match dop.load {
-          DepthLoadOp::Load => platform::render_pass::DepthLoadOp::Load,
-          DepthLoadOp::Clear(v) => {
-            platform::render_pass::DepthLoadOp::Clear(v as f32)
-          }
-        },
-        store: match dop.store {
-          StoreOp::Store => platform::render_pass::StoreOp::Store,
-          StoreOp::Discard => platform::render_pass::StoreOp::Discard,
-        },
-      }
-    });
-
-    // Map stencil operations from the high-level RenderPass
-    let platform_stencil_ops = pass.stencil_operations().map(|sop| {
-      platform::render_pass::StencilOperations {
-        load: match sop.load {
-          StencilLoadOp::Load => platform::render_pass::StencilLoadOp::Load,
-          StencilLoadOp::Clear(v) => {
-            platform::render_pass::StencilLoadOp::Clear(v)
-          }
-        },
-        store: match sop.store {
-          StoreOp::Store => platform::render_pass::StoreOp::Store,
-          StoreOp::Discard => platform::render_pass::StoreOp::Discard,
-        },
-      }
-    });
+    let (color_load_op, color_store_op) = pass.color_operations().to_platform();
+    rp_builder = rp_builder
+      .with_color_load_op(color_load_op)
+      .with_store_op(color_store_op);
+
+    // Map depth and stencil operations from the high-level RenderPass
+    let platform_depth_ops =
+      pass.depth_operations().map(|dop| dop.to_platform());
+    let platform_stencil_ops =
+      pass.stencil_operations().map(|sop| sop.to_platform());
 
     let depth_view = depth_texture.map(|dt| dt.platform_view_ref());
     let has_depth_attachment = depth_texture.is_some();

crates/lambda-rs/src/render/render_pass.rs

@@ -23,6 +23,18 @@ pub enum ColorLoadOp {
   Clear([f64; 4]),
 }
 
+impl ColorLoadOp {
+  /// Convert to the platform color load operation.
+  pub(crate) fn to_platform(self) -> platform::render_pass::ColorLoadOp {
+    return match self {
+      ColorLoadOp::Load => platform::render_pass::ColorLoadOp::Load,
+      ColorLoadOp::Clear(color) => {
+        platform::render_pass::ColorLoadOp::Clear(color)
+      }
+    };
+  }
+}
+
 /// Store operation for the first color attachment.
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum StoreOp {
@@ -32,6 +44,16 @@ pub enum StoreOp {
   Discard,
 }
 
+impl StoreOp {
+  /// Convert to the platform store operation.
+  pub(crate) fn to_platform(self) -> platform::render_pass::StoreOp {
+    return match self {
+      StoreOp::Store => platform::render_pass::StoreOp::Store,
+      StoreOp::Discard => platform::render_pass::StoreOp::Discard,
+    };
+  }
+}
+
 /// Combined color operations for the first color attachment.
 #[derive(Debug, Clone, Copy, PartialEq)]
 pub struct ColorOperations {
@@ -48,6 +70,18 @@ impl Default for ColorOperations {
   }
 }
 
+impl ColorOperations {
+  /// Convert to the platform color load and store operations.
+  pub(crate) fn to_platform(
+    self,
+  ) -> (
+    platform::render_pass::ColorLoadOp,
+    platform::render_pass::StoreOp,
+  ) {
+    return (self.load.to_platform(), self.store.to_platform());
+  }
+}
+
 /// Depth load operation for the depth attachment.
 #[derive(Debug, Clone, Copy, PartialEq)]
 pub enum DepthLoadOp {
@@ -57,6 +91,18 @@ pub enum DepthLoadOp {
   Clear(f64),
 }
 
+impl DepthLoadOp {
+  /// Convert to the platform depth load operation.
+  pub(crate) fn to_platform(self) -> platform::render_pass::DepthLoadOp {
+    return match self {
+      DepthLoadOp::Load => platform::render_pass::DepthLoadOp::Load,
+      DepthLoadOp::Clear(value) => {
+        platform::render_pass::DepthLoadOp::Clear(value as f32)
+      }
+    };
+  }
+}
+
 /// Depth operations for the first depth attachment.
 #[derive(Debug, Clone, Copy, PartialEq)]
 pub struct DepthOperations {
@@ -73,6 +119,16 @@ impl Default for DepthOperations {
   }
 }
 
+impl DepthOperations {
+  /// Convert to the platform depth operations.
+  pub(crate) fn to_platform(self) -> platform::render_pass::DepthOperations {
+    return platform::render_pass::DepthOperations {
+      load: self.load.to_platform(),
+      store: self.store.to_platform(),
+    };
+  }
+}
+
 /// Immutable parameters used when beginning a render pass.
 #[derive(Debug, Clone)]
 ///
@@ -361,6 +417,18 @@ pub enum StencilLoadOp {
   Clear(u32),
 }
 
+impl StencilLoadOp {
+  /// Convert to the platform stencil load operation.
+  pub(crate) fn to_platform(self) -> platform::render_pass::StencilLoadOp {
+    return match self {
+      StencilLoadOp::Load => platform::render_pass::StencilLoadOp::Load,
+      StencilLoadOp::Clear(value) => {
+        platform::render_pass::StencilLoadOp::Clear(value)
+      }
+    };
+  }
+}
+
 /// Stencil operations for the first stencil attachment.
 #[derive(Debug, Clone, Copy, PartialEq)]
 pub struct StencilOperations {
@@ -377,6 +445,16 @@ impl Default for StencilOperations {
   }
 }
 
+impl StencilOperations {
+  /// Convert to the platform stencil operations.
+  pub(crate) fn to_platform(self) -> platform::render_pass::StencilOperations {
+    return platform::render_pass::StencilOperations {
+      load: self.load.to_platform(),
+      store: self.store.to_platform(),
+    };
+  }
+}
+
 #[cfg(test)]
 mod tests {
   use std::cell::RefCell;