Skip to content

Commit 7ff5385

Browse files
authored
fix(client): use tracing_enabled in get_client (#1220)
1 parent a0b409b commit 7ff5385

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

langfuse/_client/get_client.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ def get_client(*, public_key: Optional[str] = None) -> Langfuse:
6565
public_key=instance.public_key,
6666
secret_key=instance.secret_key,
6767
host=instance.host,
68+
tracing_enabled=instance.tracing_enabled,
6869
)
6970

7071
else:
@@ -94,4 +95,5 @@ def get_client(*, public_key: Optional[str] = None) -> Langfuse:
9495
public_key=public_key,
9596
secret_key=instance.secret_key,
9697
host=instance.host,
98+
tracing_enabled=instance.tracing_enabled,
9799
)

langfuse/_client/resource_manager.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,9 @@ def __new__(
114114
media_upload_thread_count=media_upload_thread_count,
115115
sample_rate=sample_rate,
116116
mask=mask,
117-
tracing_enabled=tracing_enabled if tracing_enabled is not None else True,
117+
tracing_enabled=tracing_enabled
118+
if tracing_enabled is not None
119+
else True,
118120
)
119121

120122
cls._instances[public_key] = instance
@@ -140,6 +142,7 @@ def _initialize_instance(
140142
):
141143
self.public_key = public_key
142144
self.secret_key = secret_key
145+
self.tracing_enabled = tracing_enabled
143146
self.host = host
144147
self.mask = mask
145148

tests/test_core_sdk.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ def test_create_generation():
381381
assert generation_api.model_parameters == {
382382
"max_tokens": "1000",
383383
"temperature": "0.9",
384-
"stop": ["user-1", "user-2"],
384+
"stop": '["user-1","user-2"]',
385385
}
386386
assert generation_api.input == [
387387
{"role": "system", "content": "You are a helpful assistant."},

0 commit comments

Comments
 (0)