simplify

Author: hassiebp

langfuse/_task_manager/media_manager.py

@@ -270,29 +270,29 @@ def _process_upload_media_job(
     def _request_with_backoff(
         self, func: Callable[P, T], *args: P.args, **kwargs: P.kwargs
     ) -> T:
-        @backoff.on_exception(
-            backoff.expo, Exception, max_tries=self._max_retries, logger=None
-        )
-        def execute_task_with_backoff() -> T:
-            try:
-                return func(*args, **kwargs)
-            except ApiError as e:
-                if (
+        def _should_give_up(e: Exception) -> bool:
+            if isinstance(e, ApiError):
+                return (
                     e.status_code is not None
                     and 400 <= e.status_code < 500
-                    and (e.status_code) != 429
-                ):
-                    raise e
-            except requests.exceptions.RequestException as e:
-                if (
+                    and e.status_code != 429
+                )
+            if isinstance(e, requests.exceptions.RequestException):
+                return (
                     e.response is not None
-                    and hasattr(e.response, "status_code")
-                    and (e.response.status_code >= 500 or e.response.status_code == 429)
-                ):
-                    raise
-
-                raise e  # break retries for all other status codes
+                    and e.response.status_code < 500
+                    and e.response.status_code != 429
+                )
+            return False
 
-            raise Exception("Failed to execute task")
+        @backoff.on_exception(
+            backoff.expo,
+            Exception,
+            max_tries=self._max_retries,
+            giveup=_should_give_up,
+            logger=None,
+        )
+        def execute_task_with_backoff() -> T:
+            return func(*args, **kwargs)
 
         return execute_task_with_backoff()