From ba01184cb1731ad91a97f8dffd62c754c336d600 Mon Sep 17 00:00:00 2001 From: Hassieb Pakzad <68423100+hassiebp@users.noreply.github.com> Date: Tue, 3 Jun 2025 17:18:09 +0200 Subject: [PATCH 1/4] fix(langchain): deployment version added to azure model --- langfuse/extract_model.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/langfuse/extract_model.py b/langfuse/extract_model.py index 5880e9624..bee187500 100644 --- a/langfuse/extract_model.py +++ b/langfuse/extract_model.py @@ -58,7 +58,12 @@ def _extract_model_name( deployment_version = None if serialized.get("kwargs").get("deployment_name"): deployment_name = serialized.get("kwargs").get("deployment_name") - return deployment_name + "-" + deployment_version + + return ( + deployment_name + "-" + deployment_version + if deployment_version not in deployment_name + else deployment_name + ) # Third, for some models, we are unable to extract the model by a path in an object. Langfuse provides us with a string representation of the model pbjects # We use regex to extract the model from the repr string From 5af0461755ed72d40e059079558ca1642f9eddc1 Mon Sep 17 00:00:00 2001 From: Hassieb Pakzad <68423100+hassiebp@users.noreply.github.com> Date: Tue, 3 Jun 2025 17:22:09 +0200 Subject: [PATCH 2/4] Update langfuse/extract_model.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --- langfuse/extract_model.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/langfuse/extract_model.py b/langfuse/extract_model.py index bee187500..2c09f78a0 100644 --- a/langfuse/extract_model.py +++ b/langfuse/extract_model.py @@ -59,9 +59,11 @@ def _extract_model_name( if serialized.get("kwargs").get("deployment_name"): deployment_name = serialized.get("kwargs").get("deployment_name") + if not deployment_name: + return None return ( - deployment_name + "-" + deployment_version - if deployment_version not in deployment_name + f"{deployment_name}-{deployment_version}" + if deployment_version and deployment_version not in deployment_name else deployment_name ) From bd6a065ed48692e7636f14ce57b5f7b146f36e46 Mon Sep 17 00:00:00 2001 From: Hassieb Pakzad <68423100+hassiebp@users.noreply.github.com> Date: Tue, 3 Jun 2025 17:27:00 +0200 Subject: [PATCH 3/4] push --- langfuse/extract_model.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/langfuse/extract_model.py b/langfuse/extract_model.py index 2c09f78a0..8707eed0f 100644 --- a/langfuse/extract_model.py +++ b/langfuse/extract_model.py @@ -53,9 +53,11 @@ def _extract_model_name( return kwargs.get("invocation_params").get("model_name") deployment_name = None - if serialized.get("kwargs").get("openai_api_version"): - deployment_name = serialized.get("kwargs").get("deployment_version") deployment_version = None + + if serialized.get("kwargs").get("openai_api_version"): + deployment_version = serialized.get("kwargs").get("deployment_version") + if serialized.get("kwargs").get("deployment_name"): deployment_name = serialized.get("kwargs").get("deployment_name") From edf42ae8676a2cc9453aff3cf02cb615504ae4c2 Mon Sep 17 00:00:00 2001 From: Hassieb Pakzad <68423100+hassiebp@users.noreply.github.com> Date: Tue, 3 Jun 2025 17:33:04 +0200 Subject: [PATCH 4/4] push --- langfuse/extract_model.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/langfuse/extract_model.py b/langfuse/extract_model.py index 8707eed0f..cd8d58ca8 100644 --- a/langfuse/extract_model.py +++ b/langfuse/extract_model.py @@ -61,8 +61,12 @@ def _extract_model_name( if serialized.get("kwargs").get("deployment_name"): deployment_name = serialized.get("kwargs").get("deployment_name") - if not deployment_name: + if not isinstance(deployment_name, str): return None + + if not isinstance(deployment_version, str): + return deployment_name + return ( f"{deployment_name}-{deployment_version}" if deployment_version and deployment_version not in deployment_name