From 1ac7709bde3a7463a8b294c3a902afb8c1ba8781 Mon Sep 17 00:00:00 2001
From: Hassieb Pakzad <68423100+hassiebp@users.noreply.github.com>
Date: Mon, 23 Jun 2025 13:03:31 +0200
Subject: [PATCH 1/2] fix(client): use tracing_enabled in get_client

---
 langfuse/_client/get_client.py       | 2 ++
 langfuse/_client/resource_manager.py | 5 ++++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/langfuse/_client/get_client.py b/langfuse/_client/get_client.py
index 2ce1d656c..f53886e46 100644
--- a/langfuse/_client/get_client.py
+++ b/langfuse/_client/get_client.py
@@ -65,6 +65,7 @@ def get_client(*, public_key: Optional[str] = None) -> Langfuse:
                     public_key=instance.public_key,
                     secret_key=instance.secret_key,
                     host=instance.host,
+                    tracing_enabled=instance.tracing_enabled,
                 )
 
             else:
@@ -94,4 +95,5 @@ def get_client(*, public_key: Optional[str] = None) -> Langfuse:
                 public_key=public_key,
                 secret_key=instance.secret_key,
                 host=instance.host,
+                tracing_enabled=instance.tracing_enabled,
             )
diff --git a/langfuse/_client/resource_manager.py b/langfuse/_client/resource_manager.py
index 72b55b276..b0acd40d8 100644
--- a/langfuse/_client/resource_manager.py
+++ b/langfuse/_client/resource_manager.py
@@ -114,7 +114,9 @@ def __new__(
                     media_upload_thread_count=media_upload_thread_count,
                     sample_rate=sample_rate,
                     mask=mask,
-                    tracing_enabled=tracing_enabled if tracing_enabled is not None else True,
+                    tracing_enabled=tracing_enabled
+                    if tracing_enabled is not None
+                    else True,
                 )
 
                 cls._instances[public_key] = instance
@@ -140,6 +142,7 @@ def _initialize_instance(
     ):
         self.public_key = public_key
         self.secret_key = secret_key
+        self.tracing_enabled = tracing_enabled
         self.host = host
         self.mask = mask
 

From 2d1cec6c4d7d651d7b313e95f8bb4bd65c5d630b Mon Sep 17 00:00:00 2001
From: Hassieb Pakzad <68423100+hassiebp@users.noreply.github.com>
Date: Mon, 23 Jun 2025 15:44:13 +0200
Subject: [PATCH 2/2] fix test

---
 tests/test_core_sdk.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/test_core_sdk.py b/tests/test_core_sdk.py
index 914b2fb65..b519d5877 100644
--- a/tests/test_core_sdk.py
+++ b/tests/test_core_sdk.py
@@ -381,7 +381,7 @@ def test_create_generation():
     assert generation_api.model_parameters == {
         "max_tokens": "1000",
         "temperature": "0.9",
-        "stop": ["user-1", "user-2"],
+        "stop": '["user-1","user-2"]',
     }
     assert generation_api.input == [
         {"role": "system", "content": "You are a helpful assistant."},