Skip to content

Commit 4eaf564

Browse files
committed
bugfix: guard clause prevents seek back
1 parent 4199790 commit 4eaf564

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/controller.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ const REFRESH_ICON = '<i class="codicon codicon-refresh"></i>'
4545
const dataArray = new Uint8Array(bufferLength)
4646

4747
const imageDataFrame = canvasContext.createImageData(2, canvasElement.height)
48+
// TODO: note this
4849
for (let i = 0; i < imageDataFrame.data.length * 4; i += 8) {
4950
for (let j = 3; j <= 7; j++) imageDataFrame.data[i + j] = 255 // = 0,0,0,255 | 255,255,255,255
5051
}
@@ -87,7 +88,7 @@ const REFRESH_ICON = '<i class="codicon codicon-refresh"></i>'
8788
durationWatch()
8889
togglePlaybackButtons('playing')
8990
} else {
90-
//suspended
91+
// Was suspended so resume it
9192
audioCtx.resume().then(() => {
9293
susresBtn.innerHTML = PAUSE_ICON
9394
startAt = Date.now()
@@ -124,6 +125,7 @@ const REFRESH_ICON = '<i class="codicon codicon-refresh"></i>'
124125
}
125126

126127
function seek(ms) {
128+
played += Date.now() - startAt
127129
if (played === 0 && ms < 0) return
128130
if (played === lengthMs && ms > 0) return
129131

@@ -138,7 +140,6 @@ const REFRESH_ICON = '<i class="codicon codicon-refresh"></i>'
138140
source.connect(analyser)
139141
source.onended = playEnd
140142

141-
played += Date.now() - startAt
142143
played += ms
143144
if (played < 0) played = 0
144145
if (played > lengthMs) played = lengthMs

0 commit comments

Comments
 (0)