Skip to content

Commit 72dc70a

Browse files
committed
add: spec-sc3.png, update vscodeignore and package.json
1 parent bf9339b commit 72dc70a

File tree

9 files changed

+31
-18
lines changed

9 files changed

+31
-18
lines changed

.vscodeignore

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
.eslintignore
2-
.eslintrc.json
3-
.git
41
.gitignore
2+
.token
53
.vscode
6-
**/.eslintrc.json
74
**/*.map
8-
**/jsconfig.json
5+
demo
6+
jsconfig.json
7+
lab
98
media/res
10-
tsconfig.json
11-
package-lock
9+
media/vscodeignore
10+
src
11+
tasks.js
1212
vsc-extension-quickstart.md
1313
webpack.config.js

CHANGELOG.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,14 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
2222
- Use resume/suspend methods
2323
- files, MB, 1.71.0
2424

25+
Known issues:
26+
- Webpack watch doesn't work as expect - it does rebuild but not each change-save
27+
- Vscode's debugging need to click run/and restart in order to launch the app (maybe only for MacOS)
28+
2529
Notes:
26-
- **Finally! This extension is working normally** 🙌🎊🎉🥳🥂
30+
- **Finally! This extension works on vscode stable version** 🙌🎊🎉🥳🥂
2731
- It turns out that vscode doesn't ship mp3 codec with its ffmpeg library (it probably got removed in the past since this extension worked before) and recently add it back in v1.71 - [Issue](https://github.com/microsoft/vscode/ssues/48494)
28-
- Put back resume/suspend since the issue got fixed for electron/chromium [Issue1052747](https://bugs.chromium.org/p/chromium/issues/detail?id=1052747) [Issue1018499](https://bugs.chromium.org/p/chromium/issues/detail?id=1018499)
32+
- Put back resume/suspend since the issue got fixed for electron/chromium - [Issue1052747](https://bugs.chromium.org/p/chromium/issues/detail?id=1052747) | [Issue1018499](https://bugs.chromium.org/p/chromium/issues/detail?id=1018499)
2933
- Reduce extension size - it was funny to see previous version use webpack to minimize the 1 file - `controller.js`
3034
- All previous versions of this extension will not work in any recent vscode versions
3135

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Spectrogram
22
This is an extension that play and display spectrogram of mp3 and flac audio files.
33

4-
![](images/spec-sc3.PNG)
4+
![](media/spec-sc3.png)
55

66
## Release Notes
77

media/spec-sc3.png

2.66 MB
Loading

package.json

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,22 @@
22
"name": "spectrogram",
33
"displayName": "Spectrogram",
44
"description": "Real-time spectrogram",
5-
"version": "1.1.0",
5+
"version": "2.0.0",
66
"publisher": "lanly-dev",
77
"engines": {
8-
"vscode": "^1.41.0"
8+
"vscode": "^1.71.0"
99
},
1010
"categories": [
1111
"Other"
1212
],
1313
"keywords": [
1414
"Audio",
15-
"Spectrogram"
15+
"spectrogram",
16+
"mp3"
1617
],
17-
"icon": "icon/spec.png",
18+
"icon": "media/spec.png",
1819
"activationEvents": [
19-
"*"
20+
"onStartupFinished"
2021
],
2122
"main": "./dist/extension.js",
2223
"contributes": {
@@ -30,18 +31,21 @@
3031
}
3132
},
3233
"scripts": {
34+
"vscode:prepublish": "npm run package",
35+
"vsce-package": "vsce package",
36+
"package": "webpack --mode production --devtool hidden-source-map",
3337
"wp": "webpack",
3438
"wp-watch": "webpack --watch",
3539
"task-clean-output": "ts-node tasks.js clean"
3640
},
3741
"devDependencies": {
38-
"@types/node": "^18.7.16",
42+
"@types/node": "^18.7.23",
3943
"@types/vscode": "^1.71.0",
4044
"@types/vscode-webview": "^1.57.0",
4145
"@vscode/codicons": "^0.0.32",
4246
"copy-webpack-plugin": "^11.0.0",
4347
"css-minimizer-webpack-plugin": "^4.1.0",
44-
"eslint": "^8.23.0",
48+
"eslint": "^8.24.0",
4549
"eslint-plugin-jsdoc": "^39.3.6",
4650
"pug": "^3.0.2",
4751
"shelljs": "^0.8.5",

src/controller.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ const REFRESH_ICON = '<i class="codicon codicon-refresh"></i>'
3333
* @param {{ path: string; name: string; }} file
3434
*/
3535
function player(file) {
36-
const WIDTH = (canvasElement.width = window.innerWidth)
36+
canvasElement.width = window.innerWidth - 10
37+
const WIDTH = canvasElement.width
3738
togglePlaybackButtons('loading')
3839
const audioCtx = new AudioContext()
3940
const analyser = audioCtx.createAnalyser()

src/style.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@
1010
padding: 0 5px;
1111
}
1212

13+
body {
14+
padding-left: 5px;
15+
}
16+
1317
button {
1418
background-color: var(--vscode-button-background);
1519
border: none;

0 commit comments

Comments
 (0)