refactor: added strict types tests

Author: alexsoft

src/Exceptions/CouldNotSendNotification.php

@@ -1,33 +1,30 @@
 <?php
 
+declare(strict_types=1);
+
 namespace NotificationChannels\Pushbullet\Exceptions;
 
-use GuzzleHttp\Exception\ClientException;
+use Psr\Http\Message\ResponseInterface;
 use RuntimeException;
 
 class CouldNotSendNotification extends RuntimeException
 {
-    public static function pushbulletRespondedWithAnError(ClientException $exception)
+    public static function pushbulletRespondedWithAnError(ResponseInterface $response): self
     {
-        $code = $exception->getResponse()->getStatusCode();
-
-        $message = $exception->getResponse()->getBody();
+        $code = $response->getStatusCode();
 
-        return new static("Pushbullet responded with an error `{$code} - {$message}`");
-    }
+        $message = $response->getBody();
 
-    public static function providedEmailIsInvalid($email)
-    {
-        return new static("Provided email `{$email}` of `notifiable` is not valid");
+        return new self("Pushbullet responded with error: `{$code} - {$message}`.");
     }
 
-    public static function couldNotSendNotificationWithoutRecipient()
+    public static function providedEmailIsInvalid(string $email): self
     {
-        return new static('Neither device id nor email of recipient was not specified');
+        return new self("Provided email `{$email}` of `notifiable` is not valid.");
     }
 
-    public static function couldNotCommunicateWithPushbullet()
+    public static function couldNotCommunicateWithPushbullet(): self
     {
-        return new static("Couldn't connect to Pushbullet API.");
+        return new self('Could not connect to Pushbullet API.');
     }
 }

src/Pushbullet.php

@@ -1,13 +1,14 @@
 <?php
 
- declare(strict_types=1);
+declare(strict_types=1);
 
 namespace NotificationChannels\Pushbullet;
 
 use Exception;
 use GuzzleHttp\Client as HttpClient;
 use GuzzleHttp\Exception\ClientException;
 use NotificationChannels\Pushbullet\Exceptions\CouldNotSendNotification;
+use Psr\Http\Message\ResponseInterface;
 
 class Pushbullet
 {
@@ -23,7 +24,7 @@ class Pushbullet
      * @param  string  $token
      * @param  \GuzzleHttp\Client  $httpClient
      */
-    public function __construct($token, HttpClient $httpClient)
+    public function __construct(string $token, HttpClient $httpClient)
     {
         $this->token = $token;
         $this->httpClient = $httpClient;
@@ -55,9 +56,10 @@ private function getHeaders(): array
      * Send request to Pushbullet API.
      *
      * @param  array  $params
+     *
      * @return \Psr\Http\Message\ResponseInterface
      */
-    public function send($params)
+    public function send($params): ResponseInterface
     {
         $url = $this->getPushbulletUrl();
 
@@ -67,7 +69,7 @@ public function send($params)
                 'headers' => $this->getHeaders(),
             ]);
         } catch (ClientException $exception) {
-            throw CouldNotSendNotification::pushbulletRespondedWithAnError($exception);
+            throw CouldNotSendNotification::pushbulletRespondedWithAnError($exception->getResponse());
         } catch (Exception $exception) {
             throw CouldNotSendNotification::couldNotCommunicateWithPushbullet();
         }

src/PushbulletChannel.php

@@ -15,7 +15,6 @@ class PushbulletChannel
     private $pushbullet;
 
     /**
-     * Create pushbullet notification channel.
      * @param  \NotificationChannels\Pushbullet\Pushbullet  $pushbullet
      */
     public function __construct(Pushbullet $pushbullet)

src/PushbulletServiceProvider.php

@@ -9,11 +9,11 @@
 
 class PushbulletServiceProvider extends ServiceProvider
 {
-    public function boot()
+    public function boot(): void
     {
         $this->app->when(PushbulletChannel::class)
             ->needs(Pushbullet::class)
-            ->give(function () {
+            ->give(static function (): Pushbullet {
                 $config = config('services.pushbullet');
 
                 return new Pushbullet($config['access_token'], new HttpClient());

src/Targets/Channel.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace NotificationChannels\Pushbullet\Targets;
 
 class Channel implements Targetable

src/Targets/Device.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace NotificationChannels\Pushbullet\Targets;
 
 class Device implements Targetable

src/Targets/Email.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace NotificationChannels\Pushbullet\Targets;
 
 use NotificationChannels\Pushbullet\Exceptions\CouldNotSendNotification;

src/Targets/Targetable.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace NotificationChannels\Pushbullet\Targets;
 
 interface Targetable