fix: Made properties in targets private, added tests

Author: alexsoft

src/Targets/Channel.php

@@ -9,7 +9,7 @@ class Channel implements Targetable
      *
      * @var string
      */
-    protected $channelTag;
+    private $channelTag;
 
     /**
      * Set channel tag.

src/Targets/Device.php

@@ -9,7 +9,7 @@ class Device implements Targetable
      *
      * @var string
      */
-    protected $deviceId;
+    private $deviceId;
 
     /**
      * Set recipient device id.

src/Targets/Email.php

@@ -11,7 +11,7 @@ class Email implements Targetable
      *
      * @var string
      */
-    protected $email;
+    private $email;
 
     /**
      * Set recipient email.

tests/Targets/ChannelTest.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+namespace NotificationChannels\Pushbullet\Test\Targets;
+
+use NotificationChannels\Pushbullet\Targets\Channel;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @coversDefaultClass \NotificationChannels\Pushbullet\Targets\Channel
+ */
+class ChannelTest extends TestCase
+{
+    /**
+     * @test
+     *
+     * @covers ::__construct
+     * @covers ::getTarget
+     */
+    public function it_is_properly_represented_as_array()
+    {
+        $sut = new Channel('channelTag');
+
+        $this->assertEquals(['channel_tag' => 'channelTag'], $sut->getTarget());
+    }
+}

tests/Targets/DeviceTest.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+namespace NotificationChannels\Pushbullet\Test\Targets;
+
+use NotificationChannels\Pushbullet\Targets\Device;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @coversDefaultClass \NotificationChannels\Pushbullet\Targets\Device
+ */
+class DeviceTest extends TestCase
+{
+    /**
+     * @test
+     *
+     * @covers ::__construct
+     * @covers ::getTarget
+     */
+    public function it_is_properly_represented_as_array()
+    {
+        $sut = new Device('deviceId');
+
+        $this->assertEquals(['device_iden' => 'deviceId'], $sut->getTarget());
+    }
+}

tests/Targets/EmailTest.php

@@ -0,0 +1,40 @@
+<?php
+
+declare(strict_types=1);
+
+namespace NotificationChannels\Pushbullet\Test\Targets;
+
+use NotificationChannels\Pushbullet\Exceptions\CouldNotSendNotification;
+use NotificationChannels\Pushbullet\Targets\Email;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @coversDefaultClass \NotificationChannels\Pushbullet\Targets\Email
+ */
+class EmailTest extends TestCase
+{
+    /**
+     * @test
+     *
+     * @covers ::__construct
+     * @covers ::getTarget
+     */
+    public function it_is_properly_represented_as_array()
+    {
+        $sut = new Email('email@example.com');
+
+        $this->assertEquals(['email' => 'email@example.com'], $sut->getTarget());
+    }
+
+    /**
+     * @test
+     *
+     * @covers ::__construct
+     */
+    public function invalid_email_is_not_accepted()
+    {
+        $this->expectException(CouldNotSendNotification::class);
+
+        $sut = new Email('email');
+    }
+}