tweaks

Author: keelerm84

contract-tests/client_entity.py

@@ -16,7 +16,7 @@
 )
 from ldclient.config import BigSegmentsConfig
 from ldclient.impl.datasourcev2.polling import PollingDataSourceBuilder
-from ldclient.impl.datasystem.config import (
+from ldclient.datasystem import (
     custom,
     polling_ds_builder,
     streaming_ds_builder

ldclient/datasystem.py

@@ -96,7 +96,7 @@ def build(self) -> DataSystemConfig:
         )
 
 
-def __polling_ds_builder() -> Builder[PollingDataSource]:
+def polling_ds_builder() -> Builder[PollingDataSource]:
     def builder(config: LDConfig) -> PollingDataSource:
         requester = Urllib3PollingRequester(config)
         polling_ds = PollingDataSourceBuilder(config)
@@ -107,7 +107,7 @@ def builder(config: LDConfig) -> PollingDataSource:
     return builder
 
 
-def __fdv1_fallback_ds_builder() -> Builder[PollingDataSource]:
+def fdv1_fallback_ds_builder() -> Builder[PollingDataSource]:
     def builder(config: LDConfig) -> PollingDataSource:
         requester = Urllib3FDv1PollingRequester(config)
         polling_ds = PollingDataSourceBuilder(config)
@@ -118,7 +118,7 @@ def builder(config: LDConfig) -> PollingDataSource:
     return builder
 
 
-def __streaming_ds_builder() -> Builder[StreamingDataSource]:
+def streaming_ds_builder() -> Builder[StreamingDataSource]:
     def builder(config: LDConfig) -> StreamingDataSource:
         return StreamingDataSourceBuilder(config).build()
 
@@ -139,9 +139,9 @@ def default() -> ConfigBuilder:
     for updates.
     """
 
-    polling_builder = __polling_ds_builder()
-    streaming_builder = __streaming_ds_builder()
-    fallback = __fdv1_fallback_ds_builder()
+    polling_builder = polling_ds_builder()
+    streaming_builder = streaming_ds_builder()
+    fallback = fdv1_fallback_ds_builder()
 
     builder = ConfigBuilder()
     builder.initializers([polling_builder])
@@ -158,8 +158,8 @@ def streaming() -> ConfigBuilder:
     with no additional latency.
     """
 
-    streaming_builder = __streaming_ds_builder()
-    fallback = __fdv1_fallback_ds_builder()
+    streaming_builder = streaming_ds_builder()
+    fallback = fdv1_fallback_ds_builder()
 
     builder = ConfigBuilder()
     builder.synchronizers(streaming_builder)
@@ -175,8 +175,8 @@ def polling() -> ConfigBuilder:
     streaming, but may be necessary in some network environments.
     """
 
-    polling_builder: Builder[Synchronizer] = __polling_ds_builder()
-    fallback = __fdv1_fallback_ds_builder()
+    polling_builder: Builder[Synchronizer] = polling_ds_builder()
+    fallback = fdv1_fallback_ds_builder()
 
     builder = ConfigBuilder()
     builder.synchronizers(polling_builder)

ldclient/testing/impl/datasystem/test_fdv2_datasystem.py

@@ -58,7 +58,7 @@ def listener(flag_change: FlagChange):
     assert set_on_ready.wait(1), "Data system did not become ready in time"
     assert initialized.wait(1), "Flag change listener was not called in time"
 
-    td_synchronizer.update(td_synchronizer.flag("feature-flag").on(False))
+    td_synchronizer.update(td_synchronizer.flag("feature-flag").on(True))
     assert modified.wait(1), "Flag change listener was not called in time"
     assert len(changes) == 3
     assert changes[0].key == "feature-flag"