have builder use no selector

Author: jsonbailey

ldclient/impl/datasourcev2/polling.py

@@ -220,7 +220,7 @@ def _poll(self, ss: SelectorStore) -> BasisResult:
 
             basis = Basis(
                 change_set=change_set,
-                persist=change_set.selector is not None,
+                persist=change_set.selector.is_defined(),
                 environment_id=env_id,
             )
 

ldclient/interfaces.py

@@ -1393,7 +1393,7 @@ def no_changes() -> "ChangeSet":
         require changes.
         """
         return ChangeSet(
-            intent_code=IntentCode.TRANSFER_NONE, selector=None, changes=[]
+            intent_code=IntentCode.TRANSFER_NONE, selector=Selector.no_selector(), changes=[]
         )
 
     @staticmethod

ldclient/testing/impl/datasourcev2/test_polling_initializer.py

@@ -7,7 +7,8 @@
     PollingDataSource,
     PollingResult,
     Selector,
-    polling_payload_to_changeset
+    polling_payload_to_changeset,
+    fdv1_polling_payload_to_changeset
 )
 from ldclient.impl.util import UnsuccessfulResponseException, _Fail, _Success
 from ldclient.interfaces import ChangeSetBuilder, IntentCode
@@ -138,3 +139,33 @@ def test_handles_transfer_changes():
     assert result.value.change_set.intent_code == IntentCode.TRANSFER_CHANGES
     assert len(result.value.change_set.changes) == 1
     assert result.value.persist is True
+
+
+def test_handles_fdv1_payload():
+    """Test that FDv1 payloads have persist set to False."""
+    fdv1_data = {
+        "flags": {
+            "test-flag": {
+                "key": "test-flag",
+                "version": 1,
+                "on": True,
+                "variations": [True, False]
+            }
+        },
+        "segments": {}
+    }
+    change_set_result = fdv1_polling_payload_to_changeset(fdv1_data)
+    assert isinstance(change_set_result, _Success)
+
+    mock_requester = MockPollingRequester(_Success(value=(change_set_result.value, {})))
+    ds = PollingDataSource(poll_interval=1.0, requester=mock_requester)
+
+    result = ds.fetch(MockSelectorStore(Selector.no_selector()))
+
+    assert isinstance(result, _Success)
+    assert result.value is not None
+
+    assert result.value.change_set.intent_code == IntentCode.TRANSFER_FULL
+    assert len(result.value.change_set.changes) == 1
+    # FDv1 payloads should not be persisted because they have no selector
+    assert result.value.persist is False

ldclient/testing/impl/datasystem/test_fdv2_persistence.py

@@ -370,7 +370,8 @@ def test_persistent_store_delete_operations():
         ChangeSet,
         ChangeType,
         IntentCode,
-        ObjectKind
+        ObjectKind,
+        Selector
     )
 
     # Pre-populate with a flag
@@ -410,7 +411,7 @@ def test_persistent_store_delete_operations():
                 },
             )
         ],
-        selector=None,
+        selector=Selector.no_selector(),
     )
     store.apply(init_changeset, True)
 
@@ -428,7 +429,7 @@ def test_persistent_store_delete_operations():
                 object=None,
             )
         ],
-        selector=None,
+        selector=Selector.no_selector(),
     )
 
     store.apply(delete_changeset, True)
@@ -671,7 +672,8 @@ def test_persistent_store_commit_encodes_data_correctly():
         ChangeSet,
         ChangeType,
         IntentCode,
-        ObjectKind
+        ObjectKind,
+        Selector
     )
 
     persistent_store = StubFeatureStore()
@@ -699,7 +701,7 @@ def test_persistent_store_commit_encodes_data_correctly():
                 object=flag_data,
             )
         ],
-        selector=None,
+        selector=Selector.no_selector(),
     )
     store.apply(changeset, True)
 
@@ -746,7 +748,8 @@ def test_persistent_store_commit_handles_errors():
         ChangeSet,
         ChangeType,
         IntentCode,
-        ObjectKind
+        ObjectKind,
+        Selector
     )
 
     class FailingFeatureStore(StubFeatureStore):
@@ -770,7 +773,7 @@ def init(self, all_data):
                 object={"key": "test-flag", "version": 1, "on": True},
             )
         ],
-        selector=None,
+        selector=Selector.no_selector(),
     )
     store.apply(changeset, True)