Skip to content

Commit 6b0920b

Browse files
fix: Correct non-string SDK key validation test
- Update test_validate_sdk_key_non_string to actually test non-string inputs - Test various non-string types: int, None, object, list, dict - Verify proper error message is logged for each invalid type Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
1 parent 133b3db commit 6b0920b

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

ldclient/testing/impl/test_util.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,13 @@ def test_validate_sdk_key_non_string():
3939
"""Test validation of non-string SDK keys"""
4040
logger = Mock(spec=logging.Logger)
4141

42-
assert validate_sdk_key("123", logger) is True
43-
logger.warning.assert_not_called()
42+
non_string_values = [123, None, object(), [], {}]
43+
44+
for value in non_string_values:
45+
result = validate_sdk_key(value, logger)
46+
assert result is False
47+
logger.warning.assert_called_with("SDK key must be a string")
48+
logger.reset_mock()
4449

4550

4651
def test_validate_sdk_key_empty():

0 commit comments

Comments
 (0)