Document store close method as optional and call if it exists

Author: jsonbailey

ldclient/impl/datasystem/fdv2.py

@@ -232,15 +232,14 @@ def is_monitoring_enabled(self) -> bool:
     def close(self):
         """
         Close the wrapper and stop the repeating task poller if it's running.
-        This is called by Store.close() during shutdown to ensure the poller thread is stopped.
+        Also forwards the close call to the underlying store if it has a close method.
         """
-        poller_to_stop = None
         with self.__lock.write():
-            poller_to_stop = self.__poller
-            self.__poller = None
-
-        if poller_to_stop is not None:
-            poller_to_stop.stop()
+            if self.__poller is not None:
+                self.__poller.stop()
+                self.__poller = None
+            if hasattr(self.store, "close"):
+                self.store.close()
 
 
 class FDv2(DataSystem):

ldclient/interfaces.py

@@ -189,6 +189,28 @@ def initialized(self) -> bool:
     #     :return: true if the underlying data store is reachable
     #     """
 
+    # WARN: This isn't a required method on a FeatureStore. The SDK will
+    # check if the provided store responds to this method, and if it does,
+    # will call it during shutdown to release any resources (such as database
+    # connections or connection pools) that the store may be using.
+    #
+    # @abstractmethod
+    # def close(self):
+    #     """
+    #     Releases any resources used by the data store implementation.
+    #
+    #     This method will be called by the SDK during shutdown to ensure proper
+    #     cleanup of resources such as database connections, connection pools,
+    #     network sockets, or other resources that should be explicitly released.
+    #
+    #     Implementations should be idempotent - calling close() multiple times
+    #     should be safe and have no additional effect after the first call.
+    #
+    #     This is particularly important for persistent data stores that maintain
+    #     connection pools or other long-lived resources that should be properly
+    #     cleaned up when the SDK is shut down.
+    #     """
+
 
 class FeatureStoreCore:
     """