Skip to content

Conversation

@wbruna
Copy link
Contributor

@wbruna wbruna commented Nov 10, 2025

This helps avoid a name conflict (for instance with the original function) when linking against the library.

Edit: fixes #1011

This helps avoid a name conflict (for instance with the original
function) when linking against the library.
Avoid a symbol conflict with the same named function from
libllama.

Fixes leejet#1011
@wbruna wbruna force-pushed the rename_get_num_physical_cores branch from 9b322d6 to dc66e20 Compare November 30, 2025 14:39
@wbruna wbruna changed the title chore: add sd_ prefix to get_num_physical_cores chore: add sd_ prefix to a few functions Nov 30, 2025
@wbruna
Copy link
Contributor Author

wbruna commented Nov 30, 2025

Added the sd_ prefix to format() too, replacing #1012 .

@leejet leejet merged commit e4c50f1 into leejet:master Dec 1, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Please consider renaming or inlining std::string format(const char* fmt, ...) in util.cpp, as it conflicts with llama.cpp def

2 participants