Skip to content

Commit 1f4f58b

Browse files
committed
Use properties instead of items for .targets tasks
1 parent c358bc3 commit 1f4f58b

File tree

1 file changed

+24
-21
lines changed

1 file changed

+24
-21
lines changed

LibGit2Sharp/CodeGenerator.targets

Lines changed: 24 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -33,18 +33,19 @@
3333
Condition=" '%(Filename)%(Extension)' == 'libgit2_filename.txt' ">
3434
<Output TaskParameter="Lines" PropertyName="libgit2FileName" />
3535
</ReadLinesFromFile>
36-
<Message Importance='high' Text='$(libgit2FileName)' />
37-
<ItemGroup>
38-
<NativeDllNameSourceLines Include='namespace LibGit2Sharp.Core' />
39-
<NativeDllNameSourceLines Include='{' />
40-
<NativeDllNameSourceLines Include=' internal static class NativeDllName' />
41-
<NativeDllNameSourceLines Include=' {' />
42-
<NativeDllNameSourceLines Include=' public const string Name = "$(libgit2FileName)"%3b' />
43-
<NativeDllNameSourceLines Include=' }' />
44-
<NativeDllNameSourceLines Include='}' />
45-
</ItemGroup>
36+
<PropertyGroup>
37+
<NativeDllNameSourceLines>
38+
namespace LibGit2Sharp.Core
39+
{
40+
internal static class NativeDllName
41+
{
42+
public const string Name = "$(libgit2FileName)"%3b
43+
}
44+
}
45+
</NativeDllNameSourceLines>
46+
</PropertyGroup>
4647
<WriteLinesToFile File="$(NativeDllNamePath)"
47-
Lines="@(NativeDllNameSourceLines)"
48+
Lines="$(NativeDllNameSourceLines)"
4849
Overwrite="true" />
4950
<ItemGroup>
5051
<Compile Include="$(NativeDllNamePath)" />
@@ -57,18 +58,20 @@
5758
<Target Name="GenerateUniqueIdentifierCs"
5859
Inputs="$(MSBuildThisFileFullPath);$(MSBuildAllProjects);@(Compile)"
5960
Outputs="$(UniqueIdentifierPath)">
60-
<ItemGroup>
61-
<UniqueIdSourceLines Include='namespace LibGit2Sharp.Core' />
62-
<UniqueIdSourceLines Include='{' />
63-
<UniqueIdSourceLines Include=' internal static class UniqueId' />
64-
<UniqueIdSourceLines Include=' {' />
65-
<UniqueIdSourceLines Include=' public const string UniqueIdentifier = "$([System.Guid]::NewGuid())"%3b' />
66-
<UniqueIdSourceLines Include=' }' />
67-
<UniqueIdSourceLines Include='}' />
68-
</ItemGroup>
61+
<PropertyGroup>
62+
<UniqueIdSourceLines>
63+
namespace LibGit2Sharp.Core
64+
{
65+
internal static class UniqueId
66+
{
67+
public const string UniqueIdentifier = "$([System.Guid]::NewGuid())"%3b
68+
}
69+
}
70+
</UniqueIdSourceLines>
71+
</PropertyGroup>
6972

7073
<WriteLinesToFile File="$(UniqueIdentifierPath)"
71-
Lines="@(UniqueIdSourceLines)"
74+
Lines="$(UniqueIdSourceLines)"
7275
Overwrite="true" />
7376

7477
<ItemGroup>

0 commit comments

Comments
 (0)