Merge pull request #927 from libgit2/ntk/issue_927

Trying to fetch all tags fails

Author: nulltoken

LibGit2Sharp.Tests/FetchFixture.cs

@@ -16,7 +16,9 @@ public class FetchFixture : BaseFixture
         [InlineData("git://github.com/libgit2/TestGitRepository.git")]
         public void CanFetchIntoAnEmptyRepository(string url)
         {
-            using (var repo = InitIsolatedRepository())
+            string path = InitNewRepository();
+
+            using (var repo = new Repository(path))
             {
                 Remote remote = repo.Network.Remotes.Add(remoteName, url);
 
@@ -53,7 +55,9 @@ public void CanFetchIntoAnEmptyRepositoryWithCredentials()
             InconclusiveIf(() => string.IsNullOrEmpty(Constants.PrivateRepoUrl),
                 "Populate Constants.PrivateRepo* to run this test");
 
-            using (var repo = InitIsolatedRepository())
+            string path = InitNewRepository();
+
+            using (var repo = new Repository(path))
             {
                 Remote remote = repo.Network.Remotes.Add(remoteName, Constants.PrivateRepoUrl);
 
@@ -71,7 +75,9 @@ public void CanFetchIntoAnEmptyRepositoryWithCredentials()
         [InlineData("git://github.com/libgit2/TestGitRepository.git")]
         public void CanFetchAllTagsIntoAnEmptyRepository(string url)
         {
-            using (var repo = InitIsolatedRepository())
+            string path = InitNewRepository();
+
+            using (var repo = new Repository(path))
             {
                 Remote remote = repo.Network.Remotes.Add(remoteName, url);
 
@@ -112,7 +118,9 @@ public void CanFetchAllTagsIntoAnEmptyRepository(string url)
         [InlineData("git://github.com/libgit2/TestGitRepository.git", "master", "first-merge")]
         public void CanFetchCustomRefSpecsIntoAnEmptyRepository(string url, string localBranchName, string remoteBranchName)
         {
-            using (var repo = InitIsolatedRepository())
+            string path = InitNewRepository();
+
+            using (var repo = new Repository(path))
             {
                 Remote remote = repo.Network.Remotes.Add(remoteName, url);
 
@@ -139,15 +147,17 @@ public void CanFetchCustomRefSpecsIntoAnEmptyRepository(string url, string local
             }
         }
 
-        [Theory(Skip = "Skipping due to recent github handling modification of --include-tag.")]
+        [Theory]
         [InlineData(TagFetchMode.All, 4)]
         [InlineData(TagFetchMode.None, 0)]
-        [InlineData(TagFetchMode.Auto, 3)]
+        //[InlineData(TagFetchMode.Auto, 3)] // TODO: Skipping due to github modification of --include-tag handling."
         public void FetchRespectsConfiguredAutoTagSetting(TagFetchMode tagFetchMode, int expectedTagCount)
         {
             string url = "http://github.com/libgit2/TestGitRepository";
 
-            using (var repo = InitIsolatedRepository())
+            string path = InitNewRepository();
+
+            using (var repo = new Repository(path))
             {
                 Remote remote = repo.Network.Remotes.Add(remoteName, url);
                 Assert.NotNull(remote);
@@ -163,5 +173,20 @@ public void FetchRespectsConfiguredAutoTagSetting(TagFetchMode tagFetchMode, int
                 Assert.Equal(expectedTagCount, repo.Tags.Count());
             }
         }
+
+        [Fact]
+        public void CanFetchAllTagsAfterAnInitialClone()
+        {
+            var scd = BuildSelfCleaningDirectory();
+
+            const string url = "https://github.com/libgit2/TestGitRepository";
+
+            string clonedRepoPath = Repository.Clone(url, scd.DirectoryPath);
+
+            using (var repo = new Repository(clonedRepoPath))
+            {
+                repo.Fetch("origin", new FetchOptions { TagFetchMode = TagFetchMode.All });
+            }
+        }
     }
 }