Skip to content

Commit 5692a25

Browse files
committed
Disable and remove Flake8.
Converting over to Ruff which has slightly different warnings for the same things, and the Flake8 warnings are being distracting.
1 parent 531e72d commit 5692a25

File tree

4 files changed

+7
-23
lines changed

4 files changed

+7
-23
lines changed

.github/workflows/python-package.yml

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -37,18 +37,6 @@ jobs:
3737
linters: isort
3838
run: isort scripts/ tcod/ tests/ examples/ --check --diff
3939

40-
flake8:
41-
runs-on: ubuntu-latest
42-
steps:
43-
- uses: actions/checkout@v3
44-
- name: Install Flake8
45-
run: pip install Flake8
46-
- name: Flake8
47-
uses: liskin/gh-problem-matcher-wrap@v2
48-
with:
49-
linters: flake8
50-
run: flake8 scripts/ tcod/ tests/
51-
5240
mypy:
5341
runs-on: ubuntu-latest
5442
steps:
@@ -88,7 +76,7 @@ jobs:
8876

8977
# This makes sure that the latest versions of the SDL headers parse correctly.
9078
parse_sdl:
91-
needs: [black, isort, flake8, mypy]
79+
needs: [black, isort, mypy]
9280
runs-on: ${{ matrix.os }}
9381
strategy:
9482
matrix:
@@ -112,7 +100,7 @@ jobs:
112100
SDL_VERSION: ${{ matrix.sdl-version }}
113101

114102
build:
115-
needs: [black, isort, flake8, mypy]
103+
needs: [black, isort, mypy]
116104
runs-on: ${{ matrix.os }}
117105
strategy:
118106
matrix:
@@ -176,7 +164,7 @@ jobs:
176164
retention-days: 7
177165

178166
isolated: # Test installing the package from source.
179-
needs: [black, isort, flake8, mypy, sdist]
167+
needs: [black, isort, mypy, sdist]
180168
runs-on: ${{ matrix.os }}
181169
strategy:
182170
matrix:
@@ -206,7 +194,7 @@ jobs:
206194
python -c "import tcod"
207195
208196
linux-wheels:
209-
needs: [black, isort, flake8, mypy]
197+
needs: [black, isort, mypy]
210198
runs-on: "ubuntu-latest"
211199
strategy:
212200
matrix:
@@ -255,7 +243,7 @@ jobs:
255243
retention-days: 7
256244

257245
build-macos:
258-
needs: [black, isort, flake8, mypy]
246+
needs: [black, isort, mypy]
259247
runs-on: "macos-11"
260248
strategy:
261249
fail-fast: true

.vscode/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"files.insertFinalNewline": true,
1212
"files.trimTrailingWhitespace": true,
1313
"python.linting.enabled": true,
14-
"python.linting.flake8Enabled": true,
14+
"python.linting.flake8Enabled": false,
1515
"python.linting.mypyEnabled": true,
1616
"python.linting.mypyArgs": [
1717
"--follow-imports=silent",

build_libtcod.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ def generate_enums(prefix: str) -> Iterator[str]:
317317
_, name = symbol.split("_", 1)
318318
if name.isdigit():
319319
name = f"N{name}"
320-
if name in "IOl": # Handle Flake8 warnings.
320+
if name in "IOl": # Ignore ambiguous variable name warnings.
321321
yield f"{name} = {value} # noqa: E741"
322322
else:
323323
yield f"{name} = {value}"

setup.cfg

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,3 @@ py-limited-api = cp36
33

44
[aliases]
55
test=pytest
6-
7-
[flake8]
8-
ignore = E203 W503 TYP001
9-
max-line-length = 130

0 commit comments

Comments
 (0)