Split linting and packaging workflows.

Fix minor Flake8 warnings.

Add an isort config to the example directory so that the tcod import
is treated correctly.

Author: HexDecimal

.github/workflows/python-lint.yml

@@ -0,0 +1,54 @@
+# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
+# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
+
+name: Lint
+
+on: [push, pull_request]
+
+jobs:
+  lint:
+    runs-on: ubuntu-20.04
+    env:
+      python-version: '3.9'
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v2
+    - name: Checkout submodules
+      run: |
+        git submodule update --init --recursive --depth 1
+    - name: Set up Python ${{ env.python-version }}
+      uses: actions/setup-python@v2
+      with:
+        python-version: ${{ env.python-version }}
+    - name: Install Python dependencies
+      run: |
+        python -m pip install --upgrade pip
+        python -m pip install flake8 mypy black isort
+        if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
+    - name: Fake initialize package
+      run: |
+        echo '__version__ = ""' > tcod/version.py
+    - name: Flake8
+      uses: liskin/gh-problem-matcher-wrap@v1
+      with:
+        linters: flake8
+        run: flake8 tcod/
+    - name: MyPy
+      if: always()
+      uses: liskin/gh-problem-matcher-wrap@v1
+      with:
+        linters: mypy
+        run: mypy --show-column-numbers tcod/
+    - name: isort
+      uses: liskin/gh-problem-matcher-wrap@v1
+      with:
+        linters: isort
+        run: isort tcod/ tests/ --check
+    - name: isort (examples)
+      uses: liskin/gh-problem-matcher-wrap@v1
+      with:
+        linters: isort
+        run: isort examples/ --check --thirdparty tcod
+    - name: Black
+      run: |
+        black --check tcod/

.github/workflows/python-package.yml

@@ -42,29 +42,11 @@ jobs:
     - name: Install Python dependencies
       run: |
         python -m pip install --upgrade pip
-        python -m pip install flake8 mypy pytest pytest-cov pytest-benchmark black isort wheel
+        python -m pip install pytest pytest-cov pytest-benchmark wheel
         if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
     - name: Initialize package
       run: |
         python setup.py check  # Creates tcod/version.py.
-    - name: Lint with flake8
-      run: |
-        # stop the build if there are Python syntax errors or undefined names
-        flake8 tcod/ --count --select=E9,F63,F7,F82 --show-source --statistics
-        # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
-        flake8 tcod/ --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
-    - name: Check type hints with MyPy
-      if: ${{ matrix.python-version != '3.6' }}
-      run: |
-        mypy tcod/
-    - name: Check formatting with Black
-      run: |
-        black --check tcod/
-    - name: Check import order
-      run: |
-        isort tcod/ --check --diff
-        isort tests/ --check --diff
-        isort examples/ --check --diff --thirdparty tcod
     - name: Build package.
       run: |
         python setup.py build sdist develop bdist_wheel --py-limited-api cp36  # Install the package in-place.

examples/.isort.cfg

@@ -0,0 +1,5 @@
+[isort]
+profile= black
+py_version = 36
+skip_gitignore = true
+line_length = 79

setup.cfg

@@ -20,6 +20,7 @@ filterwarnings =
 
 [flake8]
 ignore = E203 W503
+max-line-length = 120
 
 [mypy]
 python_version = 3.6

tcod/context.py

@@ -56,7 +56,7 @@
 import tcod
 import tcod.event
 import tcod.tileset
-from tcod._internal import _check, _check_warn, deprecate, pending_deprecate
+from tcod._internal import _check, _check_warn, pending_deprecate
 from tcod.loader import ffi, lib
 
 __all__ = (

tcod/libtcodpy.py

@@ -1628,7 +1628,7 @@ def console_hline(
     con: tcod.console.Console,
     x: int,
     y: int,
-    l: int,
+    l: int,  # noqa: E741
     flag: int = BKGND_DEFAULT,
 ) -> None:
     """Draw a horizontal line on the console.
@@ -1646,7 +1646,7 @@ def console_vline(
     con: tcod.console.Console,
     x: int,
     y: int,
-    l: int,
+    l: int,  # noqa: E741
     flag: int = BKGND_DEFAULT,
 ) -> None:
     """Draw a vertical line on the console.