Skip to content

Commit f2d23ce

Browse files
committed
Use requests package instead of urlretrieve.
Fixes certificate issues, at least on Windows.
1 parent 52f8ba9 commit f2d23ce

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

build_sdl.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
import zipfile
1212
from pathlib import Path
1313
from typing import Any, Dict, List, Set
14-
from urllib.request import urlretrieve
1514

1615
import pcpp # type: ignore
16+
import requests
1717

1818
BITSIZE, LINKAGE = platform.architecture()
1919

@@ -97,7 +97,9 @@ def get_sdl2_file(version: str) -> Path:
9797
if not sdl2_local_file.exists():
9898
print(f"Downloading {sdl2_remote_file}")
9999
os.makedirs("dependencies/", exist_ok=True)
100-
urlretrieve(sdl2_remote_file, sdl2_local_file)
100+
with requests.get(sdl2_remote_file) as response:
101+
response.raise_for_status()
102+
sdl2_local_file.write_bytes(response.content)
101103
return sdl2_local_file
102104

103105

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ requires = [
55
"cffi>=1.15",
66
"pycparser>=2.14",
77
"pcpp==1.30",
8+
"requests>=2.28.1",
89
]
910
build-backend = "setuptools.build_meta"
1011

requirements.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
cffi>=1.15
22
numpy>=1.21.4
33
pycparser>=2.14
4+
requests>=2.28.1
45
setuptools==60.8.2
6+
types-requests
57
types-setuptools
68
types-tabulate
79
typing_extensions

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ def check_sdl_version() -> None:
115115
setup_requires=[
116116
*pytest_runner,
117117
"cffi>=1.15",
118+
"requests>=2.28.1",
118119
"pycparser>=2.14",
119120
"pcpp==1.30",
120121
],

0 commit comments

Comments
 (0)