Refactor config map data hash calculation in lightrunjavaagent_controller.go for improved clarity and maintainability

eliranb · eliranb · commit 191419bda6d7 · 2025-05-04T17:28:41.000+03:00
diff --git a/internal/controller/lightrunjavaagent_controller.go b/internal/controller/lightrunjavaagent_controller.go
@@ -242,7 +242,7 @@ func (r *LightrunJavaAgentReconciler) reconcileDeployment(ctx context.Context, l
 		}
 		return r.errorStatus(ctx, lightrunJavaAgent, err)
 	}
-	cmDataHash := hash(cm.Data["config"] + cm.Data["metadata"])
+	cmDataHash := configMapDataHash(cm.Data)
 
 	// Server side apply
 	log.V(2).Info("Patching deployment, SSA", "Deployment", lightrunJavaAgent.Spec.DeploymentName, "LightunrJavaAgent", lightrunJavaAgent.Name)

Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,7 @@ func (r *LightrunJavaAgentReconciler) reconcileDeployment(ctx context.Context, l`
`242`	`242`	`}`
`243`	`243`	`return r.errorStatus(ctx, lightrunJavaAgent, err)`
`244`	`244`	`}`
`245`		`- cmDataHash := hash(cm.Data["config"] + cm.Data["metadata"])`
	`245`	`+ cmDataHash := configMapDataHash(cm.Data)`
`246`	`246`
`247`	`247`	`// Server side apply`
`248`	`248`	`log.V(2).Info("Patching deployment, SSA", "Deployment", lightrunJavaAgent.Spec.DeploymentName, "LightunrJavaAgent", lightrunJavaAgent.Name)`