fix all compile errors when apply clang tidy

Author: linoxoidunix

CMakeLists.txt

@@ -137,6 +137,9 @@ set_target_properties(benchmark PROPERTIES CXX_CLANG_TIDY "${CLANG_TIDY_FOR_3RD_
 set_target_properties(gtest_main PROPERTIES CXX_CLANG_TIDY "${CLANG_TIDY_FOR_3RD_PARTY}")
 set_target_properties(gtest PROPERTIES CXX_CLANG_TIDY "${CLANG_TIDY_FOR_3RD_PARTY}")
 set_target_properties(simdjson PROPERTIES CXX_CLANG_TIDY "${CLANG_TIDY_FOR_3RD_PARTY}")
+set_target_properties(gmock_main PROPERTIES CXX_CLANG_TIDY "${CLANG_TIDY_FOR_3RD_PARTY}")
+set_target_properties(gmock PROPERTIES CXX_CLANG_TIDY "${CLANG_TIDY_FOR_3RD_PARTY}")
+
 
 # set(DOWNLOAD_DEPENDENCIES ON CACHE BOOL "Download dependencies for mlpack")
 

aoe/binance/execution_event/i_types.h

@@ -1,8 +1,8 @@
 #pragma once
+#include "aos/common/exchange_id.h"
 #include "aos/common/ref_counted.h"
 #include "aos/position_storage/position_storage_by_pair/i_position_storage_by_pair.h"
 #include "aos/trading_pair/trading_pair.h"
-#include "aos/common/exchange_id.h"
 
 namespace aoe {
 namespace binance {
@@ -11,7 +11,7 @@ class ExecutionEventInterface
     : public common::RefCounted<
           MemoryPool, ExecutionEventInterface<MemoryPool, PositionT>> {
   public:
-    virtual ~ExecutionEventInterface() = default;
+    ~ExecutionEventInterface() override = default;
     virtual double Fee() const { return fee_; }
     virtual double ExecPrice() const { return exec_price_; }
     virtual double ExecQty() const = 0;

aoe/binance/infrastructure/i_infrastructure.h

@@ -63,7 +63,7 @@ class InfrastructureNotifierInterface
     : public InfrastructureNotifierOnBestBidChangeInterface<Price, Qty>,
       public InfrastructureNotifierOnBestAskChangeInterface<Price, Qty> {
   public:
-    virtual ~InfrastructureNotifierInterface() = default;
+    ~InfrastructureNotifierInterface() override = default;
 };
 };  // namespace main_net
 };  // namespace spot

aoe/binance/leaves_qty_calculator/leaves_qty_calculator.h

@@ -8,7 +8,8 @@ template <template <typename> typename MemoryPool>
 class LeavesQtyCalculator : public LeavesQtyCalculatorInterface<MemoryPool> {
   public:
     ~LeavesQtyCalculator() override = default;
-    double Calculate(const OrderEventInterface<MemoryPool>& event) const {
+    double Calculate(
+        const OrderEventInterface<MemoryPool>& event) const override {
         return event.OrderQty() - event.CumExecQty();
     };
 };

aoe/binance/order_event/i_order_event.h

@@ -11,7 +11,7 @@ namespace binance {
 template <template <typename> typename MemoryPool>
 class OrderEventInterface : public aos::OrderEventInterface<MemoryPool> {
   public:
-    virtual ~OrderEventInterface() = default;
+    ~OrderEventInterface() override = default;
     virtual void SetTradingPair(aos::TradingPair trading_pair) {
         trading_pair_ = trading_pair;
     };

aoe/binance/parser/json/ws/execution_response/execution_event_parser.h

@@ -40,7 +40,7 @@ class ExecutionEventParser
         RegisterFromConfig();
     }
     std::pair<bool, EventPtr> ParseAndCreate(
-        simdjson::ondemand::document& doc) {
+        simdjson::ondemand::document& doc) override {
         // Тип исполнения может быть NEW, TRADE, FILLED и т.д.
         auto exec_type = doc["x"];
         if (exec_type.error() != simdjson::SUCCESS ||
@@ -132,7 +132,7 @@ class ExecutionEventParser
         RegisterFromConfig();
     }
     std::pair<bool, EventPtr> ParseAndCreate(
-        simdjson::ondemand::document& doc) {
+        simdjson::ondemand::document& doc) override {
         // Тип исполнения может быть NEW, TRADE, FILLED и т.д.
         auto exec_type = doc["x"];
         if (exec_type.error() != simdjson::SUCCESS ||

aoe/bybit/api/i_exchange_api.h

@@ -66,15 +66,15 @@ class SingleOrderAPIInterface : public PlaceOrderInterface<MemoryPool>,
                                 public CancelOrderInterface<MemoryPool>,
                                 public CancelAllOrderInterface<MemoryPool> {
   public:
-    virtual ~SingleOrderAPIInterface() = default;
+    ~SingleOrderAPIInterface() override = default;
 };
 
 template <template <typename> typename MemoryPool>
 class BatchOrderAPIInterface : public PlaceBacthOrderInterface<MemoryPool>,
                                public AmendBatchOrderInterface<MemoryPool>,
                                public CancelBatchOrderInterface<MemoryPool> {
   public:
-    virtual ~BatchOrderAPIInterface() = default;
+    ~BatchOrderAPIInterface() override = default;
 };
 };  // namespace bybit
 };  // namespace aoe

aoe/bybit/execution_event/i_types.h

@@ -1,8 +1,8 @@
 #pragma once
+#include "aos/common/exchange_id.h"
 #include "aos/common/ref_counted.h"
 #include "aos/position_storage/position_storage_by_pair/i_position_storage_by_pair.h"
 #include "aos/trading_pair/trading_pair.h"
-#include "aos/common/exchange_id.h"
 
 namespace aoe {
 namespace bybit {
@@ -11,7 +11,7 @@ class ExecutionEventInterface
     : public common::RefCounted<
           MemoryPool, ExecutionEventInterface<MemoryPool, PositionT>> {
   public:
-    virtual ~ExecutionEventInterface() = default;
+    ~ExecutionEventInterface() override = default;
     virtual double Fee() const { return fee_; }
     virtual double ExecPrice() const { return exec_price_; }
     virtual double ExecQty() const = 0;

aoe/bybit/execution_watcher/execution_watcher.h

@@ -66,7 +66,7 @@ class ExecutionWatcherDefault
         : position_storage_(position_storage) {};
     void OnEvent(
         boost::intrusive_ptr<ExecutionEventInterface<MemoryPool, PositionT>>
-            event) {
+            event) override {
         event->Accept(position_storage_);
     };
     ~ExecutionWatcherDefault() = default;

aoe/bybit/infrastructure/i_infrastructure.h

@@ -63,7 +63,7 @@ class InfrastructureNotifierInterface
     : public InfrastructureNotifierOnBestBidChangeInterface<Price, Qty>,
       public InfrastructureNotifierOnBestAskChangeInterface<Price, Qty> {
   public:
-    virtual ~InfrastructureNotifierInterface() = default;
+    ~InfrastructureNotifierInterface() override = default;
 };
 };  // namespace main_net
 };  // namespace spot