Refactor code for consistency and improvements

- Renamed `ExecutionEventParserInterface` to `TradeEventParserInterface` for clarity
- Made `Acceptor` constructor explicit in funding rate event handler
- Simplified WebSocket error handling logic by removing redundant checks
- Updated `MarketType` and `ActionType` enums to use `k` prefix (e.g., `kSpot`, `kBuy`)
- Added missing `#include <cstdint>` in trading_pair_triangle.h
- Improved enum formatting in `fmt::formatter` specialization
- Cleaned up example main functions (removed unused args, fixed scope)
- Minor code style improvements (variable naming, comments)

Author: linoxoidunix

aoe/binance/parser/json/ws/trade_response/i_trade_event_parser.h

@@ -6,9 +6,9 @@
 namespace aoe {
 namespace binance {
 template <template <typename> typename MemoryPool, typename PositionT>
-class ExecutionEventParserInterface {
+class TradeEventParserInterface {
   public:
-    virtual ~ExecutionEventParserInterface() = default;
+    virtual ~TradeEventParserInterface() = default;
     using EventPtr =
         boost::intrusive_ptr<ExecutionEventInterface<MemoryPool, PositionT>>;
     virtual std::pair<bool, EventPtr> ParseAndCreate(

aoe/binance/parser/json/ws/trade_response/trade_event_parser.h

@@ -16,7 +16,7 @@ namespace spot {
 namespace impl {
 template <template <typename> typename MemoryPool, typename PositionT>
 class TradeEventParser
-    : public ExecutionEventParserInterface<MemoryPool, PositionT> {
+    : public TradeEventParserInterface<MemoryPool, PositionT> {
     using EventPtr =
         boost::intrusive_ptr<ExecutionEventInterface<MemoryPool, PositionT>>;
     using Key       = std::string_view;

aoe/bybit/events_acceptor/funding_rate_event/acceptor.h

@@ -21,8 +21,8 @@ class Acceptor
     bool received_snapshot_success_ = false;
 
   public:
-    Acceptor(boost::asio::thread_pool& thread_pool
-             /*need pass entity to process funding rate event*/)
+    explicit Acceptor(boost::asio::thread_pool& thread_pool
+                      /*need pass entity to process funding rate event*/)
         : strand_(boost::asio::make_strand(thread_pool)) {}
     ~Acceptor() override = default;
     void OnEvent(

aoe/session/web_socket/web_socket.h

@@ -212,14 +212,10 @@ class WebSocketSessionRW : public WebSocketSessionWritableInterface,
 
             // Обрабатываем результат чтения
             if (read_ec) {
-                if (read_ec == boost::asio::error::operation_aborted) {
-                    // CloseSessionFast();
-                    break;
-                } else {
+                if (read_ec != boost::asio::error::operation_aborted) {
                     loge("Read error: {}", read_ec.message());
-                    // CloseSessionFast();
-                    break;
                 }
+                break;
             }
 
             logi("invoke callback received_bytes:{}", n);
@@ -467,12 +463,10 @@ class WebSocketSessionW : public WebSocketSessionWritableInterface {
 
             // Обрабатываем результат чтения
             if (read_ec) {
-                if (read_ec == boost::asio::error::operation_aborted) {
-                    break;
-                } else {
+                if (read_ec != boost::asio::error::operation_aborted) {
                     loge("Read error: {}", read_ec.message());
-                    break;
                 }
+                break;
             }
 
             logi("invoke callback received_bytes:{}", n);

aos/market_type/market_type.h

@@ -3,9 +3,9 @@
 
 namespace aos {
 enum class MarketType : uint8_t {
-    Spot,
-    Margin,  // Cross
-    IsolatedMargin
+    kSpot,
+    kMargin,  // Cross
+    kIsolatedMargin
 };
 };
 

aos/trading_pair_triangle/trading_pair_triangle.h

@@ -1,13 +1,14 @@
 #pragma once
 #include <array>
+#include <cstdint>
 
 #include "aos/converters/tickers_to_trading_pair/converter.h"
 #include "aos/market_type/market_type.h"
 #include "aos/trading_pair/trading_pair.h"
 
 namespace aos {
 
-enum class ActionType { Buy, Sell };
+enum class ActionType : uint8_t { kBuy, kSell };
 
 struct Action {
     ActionType action_type;
@@ -17,11 +18,11 @@ struct Action {
 
 namespace spot {
 inline Action Buy(TradingPair trading_pair) {
-    return Action{ActionType::Buy, MarketType::Spot, trading_pair};
+    return Action{ActionType::kBuy, MarketType::kSpot, trading_pair};
 }
 
 inline Action Sell(TradingPair trading_pair) {
-    return Action{ActionType::Sell, MarketType::Spot, trading_pair};
+    return Action{ActionType::kSell, MarketType::kSpot, trading_pair};
 }
 }  // namespace spot
 
@@ -49,9 +50,9 @@ class fmt::formatter<aos::Action> {
     template <typename Context>
     constexpr auto format(const aos::Action& foo, Context& ctx) const {
         auto action_type = foo.action_type;
-        std::string actionStr =
-            (action_type == aos::ActionType::Buy ? "BUY" : "SELL");
-        return fmt::format_to(ctx.out(), "{} {} on {}", actionStr,
+        std::string action_str =
+            (action_type == aos::ActionType::kBuy ? "BUY" : "SELL");
+        return fmt::format_to(ctx.out(), "{} {} on {}", action_str,
                               foo.trading_pair, foo.market_type);
     }
 };

examples/example45/main.cpp

@@ -10,7 +10,7 @@
 #include "aos/order_book_level/order_book_level.h"
 #include "concurrentqueue.h"
 
-int main(int, char** argv) {
+int main(int, char**) {
     try {
         boost::asio::thread_pool thread_pool;
         LogPolling log_polling(thread_pool, std::chrono::microseconds(1));

examples/example46/main.cpp

@@ -4,7 +4,7 @@
 #include "aos/logger/mylog.h"
 #include "aos/trading_pair_triangle/trading_pair_triangle.h"
 
-int main(int, char** argv) {
+int main() {
     {
         auto t = aos::MakeTriangle(aos::spot::Buy(aos::TradingPair::kETHUSDT),
                                    aos::spot::Sell(aos::TradingPair::kETHBTC),

examples/example47/main.cpp

@@ -136,8 +136,8 @@ void wait_for_user_input(std::promise<void>& exit_signal) {
 
 int main(int, char**) {
     {
-        boost::asio::thread_pool thread_pool;
         try {
+            boost::asio::thread_pool thread_pool;
             using HashT = uint64_t;
             using Price = double;
             fmtlog::setLogLevel(fmtlog::LogLevel::DBG);