Commit 8db7dc8
committed
refactor: ensure that using previous replaced does not remove files and reload unless necessary
The old implemenation of `previous: replaced` would remove all files and reload the
firewall every time, even if not necessary - it wasn't technically idempotent, although
it would check the new files to see if they matched the old files, and report
`changed: false` if nothing actually changed state.
The new implementation uses an in-memory backend to apply the changes, then checks if
anything changed, and then removes the files and reloads firewall only if something
actually changed.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>1 parent d949b33 commit 8db7dc8
File tree
22 files changed
+3643
-933
lines changed- files
- library
- module_utils/firewall_lsr
- tasks
- tests
- roles/linux-system-roles.firewall
- unit
22 files changed
+3643
-933
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
818 | 818 | | |
819 | 819 | | |
820 | 820 | | |
821 | | - | |
| 821 | + | |
| 822 | + | |
822 | 823 | | |
823 | 824 | | |
824 | | - | |
| 825 | + | |
825 | 826 | | |
826 | 827 | | |
827 | 828 | | |
828 | 829 | | |
829 | | - | |
| 830 | + | |
830 | 831 | | |
831 | 832 | | |
832 | | - | |
| 833 | + | |
833 | 834 | | |
834 | 835 | | |
835 | | - | |
836 | | - | |
837 | | - | |
838 | 836 | | |
839 | 837 | | |
840 | 838 | | |
| |||
This file was deleted.
0 commit comments