|
1 | | -<!--- Provide a general summary of your changes in the Title above --> |
| 1 | +## Description |
2 | 2 |
|
3 | | -[linuxserverurl]: https://linuxserver.io |
4 | | -[][linuxserverurl] |
| 3 | +Required: Please provide a brief description of what this pull request is trying to accomplish. |
5 | 4 |
|
| 5 | +> |
6 | 6 |
|
7 | | -<!--- Before submitting a pull request please check the following --> |
| 7 | +## Context, Consequences, & Considerations |
8 | 8 |
|
9 | | -<!--- If this is a fix for a typo (in code, documentation, or the README) please file an issue and let us sort it out. We do not need a PR --> |
10 | | -<!--- Ask yourself if this modification is something the whole userbase will benefit from, if this is a specific change for corner case functionality or plugins please look at making a Docker Mod or local script https://blog.linuxserver.io/2019/09/14/customizing-our-containers/ --> |
11 | | -<!--- That if the PR is addressing an existing issue include, closes #<issue number> , in the body of the PR commit message --> |
12 | | -<!--- You have included links to any files / patches etc your PR may be using in the body of the PR commit message --> |
13 | | -<!--- We maintain a changelog of major revisions to the container at the end of readme-vars.yml in the root of this repository, please add your changes there if appropriate --> |
| 9 | +Required: Please step through the following list, pausing at each item to consider your change in relation to the item's context. |
| 10 | +Check the box to mark that it applies, and enter your relevant notes under the item. |
14 | 11 |
|
| 12 | +- [ ] Security: This has security implications. This includes (but not limited to) adding users, modifying user/app permissions, network rules/policies, changing a system interconnection, or changing an authorization strategy. |
| 13 | + - [ ] This PR does not require security review. These changes are part of a project plan that has already undergone security review. The link is provided below. |
| 14 | + - [ ] This PR requires security review. Add the `security` label to this PR then request a review from the [Security Code Reviewers Team](https://github.com/orgs/civisanalytics/teams/security-code-reviewers). |
15 | 15 |
|
16 | | -<!--- Coding guidelines: --> |
17 | | -<!--- 1. Installed packages in the Dockerfiles should be in alphabetical order --> |
18 | | -<!--- 2. Changes to Dockerfile should be replicated in Dockerfile.armhf and Dockerfile.aarch64 if applicable --> |
19 | | -<!--- 3. Indentation style (tabs vs 4 spaces vs 1 space) should match the rest of the document --> |
20 | | -<!--- 4. Readme is auto generated from readme-vars.yml, make your changes there --> |
| 16 | +> |
21 | 17 |
|
22 | | ------------------------------- |
| 18 | +- [ ] Execution: This change requires commands to be run outside of the normal merge. |
23 | 19 |
|
24 | | - - [ ] I have read the [contributing](https://github.com/linuxserver/docker-code-server/blob/master/.github/CONTRIBUTING.md) guideline and understand that I have made the correct modifications |
| 20 | +> |
25 | 21 |
|
26 | | ------------------------------- |
| 22 | +- [ ] Impact: This change may cause service interruptions. |
27 | 23 |
|
28 | | -<!--- We welcome all PR’s though this doesn’t guarantee it will be accepted. --> |
| 24 | +> |
29 | 25 |
|
30 | | -## Description: |
31 | | -<!--- Describe your changes in detail --> |
| 26 | +- [ ] Testing: How did you test this change (unit tests, acceptance tests, etc.)? Did you do any manual testing? |
32 | 27 |
|
33 | | -## Benefits of this PR and context: |
34 | | -<!--- Please explain why we should accept this PR. If this fixes an outstanding bug, please reference the issue # --> |
| 28 | +> |
35 | 29 |
|
36 | | -## How Has This Been Tested? |
37 | | -<!--- Please describe in detail how you tested your changes. --> |
38 | | -<!--- Include details of your testing environment, and the tests you ran to --> |
39 | | -<!--- see how your change affects other areas of the code, etc. --> |
| 30 | +- [ ] Testing: How will you confirm this change once it's merged? |
40 | 31 |
|
| 32 | +> |
41 | 33 |
|
42 | | -## Source / References: |
43 | | -<!--- Please include any forum posts/github links relevant to the PR --> |
| 34 | +- [ ] Documentation: Documentation to reflect this change has been added to Confluence or Zendesk. |
| 35 | + |
| 36 | +> |
| 37 | +
|
| 38 | +- [ ] **All items of the checklist have been considered and this PR description is complete.** |
0 commit comments