Fix Alias & Ghost Argument Mismatch (#127)

Author: rcosta358

liquidjava-example/src/main/java/testSuite/ErrorAliasArgumentSize.java

@@ -1,4 +1,4 @@
-// Not Found Error
+// Argument Mismatch Error
 package testSuite;
 
 import liquidjava.specification.Refinement;

liquidjava-example/src/main/java/testSuite/ErrorAliasEmptyArguments.java

@@ -0,0 +1,15 @@
+// Argument Mismatch Error
+package testSuite;
+
+import liquidjava.specification.Refinement;
+import liquidjava.specification.RefinementAlias;
+
+@SuppressWarnings("unused")
+@RefinementAlias("InRange(int val, int low, int up) {low < val && val < up}")
+public class ErrorAliasEmptyArguments {
+
+    public static void main(String[] args) {
+        @Refinement("InRange()")
+        int j = 15;
+    }
+}

liquidjava-example/src/main/java/testSuite/ErrorAliasNotFound.java

@@ -0,0 +1,12 @@
+// Not Found Error
+package testSuite;
+
+import liquidjava.specification.Refinement;
+
+public class ErrorAliasNotFound {
+
+    public static void main(String[] args) {
+        @Refinement("UndefinedAlias(x)")
+        int x = 5;
+    }
+}

liquidjava-example/src/main/java/testSuite/ErrorAliasTypeMismatch.java

@@ -1,4 +1,4 @@
-// Refinement Error
+// Argument Mismatch Error
 package testSuite;
 
 import liquidjava.specification.Refinement;
@@ -15,6 +15,5 @@ public static void main(String[] args) {
 
         @Refinement("Positive(_)")
         double positive = positiveGrade2;
-        // Positive(_)   fica   positive > 0
     }
 }

liquidjava-example/src/main/java/testSuite/ErrorGhostArgsTypes.java

@@ -1,4 +1,4 @@
-// Error
+// Argument Mismatch Error
 package testSuite;
 
 import liquidjava.specification.Refinement;

liquidjava-example/src/main/java/testSuite/ErrorGhostNotFound.java

@@ -0,0 +1,12 @@
+// Not Found Error
+package testSuite;
+
+import liquidjava.specification.Refinement;
+
+public class ErrorGhostNotFound {
+
+    public void test() {
+        @Refinement("notFound(x)")
+        int x = 5;
+    }
+}

liquidjava-example/src/main/java/testSuite/ErrorGhostNumberArgs.java

@@ -1,4 +1,4 @@
-// Error
+// Argument Mismatch Error
 package testSuite;
 
 import liquidjava.specification.Refinement;

liquidjava-verifier/src/main/java/liquidjava/diagnostics/Diagnostics.java

@@ -55,11 +55,10 @@ public void clear() {
     }
 
     public String getErrorOutput() {
-        return String.join("\n", errors.stream().map(LJError::toString).toList()) + (errors.isEmpty() ? "" : "\n");
+        return String.join("\n", errors.stream().map(LJError::toString).toList());
     }
 
     public String getWarningOutput() {
-        return String.join("\n", warnings.stream().map(LJWarning::toString).toList())
-                + (warnings.isEmpty() ? "" : "\n");
+        return String.join("\n", warnings.stream().map(LJWarning::toString).toList());
     }
 }

liquidjava-verifier/src/main/java/liquidjava/diagnostics/LJDiagnostic.java

@@ -10,9 +10,9 @@ public class LJDiagnostic extends RuntimeException {
 
     private final String title;
     private final String message;
-    private final String file;
-    private final ErrorPosition position;
     private final String accentColor;
+    private String file;
+    private ErrorPosition position;
 
     public LJDiagnostic(String title, String message, SourcePosition pos, String accentColor) {
         this.title = title;
@@ -38,6 +38,13 @@ public ErrorPosition getPosition() {
         return position;
     }
 
+    public void setPosition(SourcePosition pos) {
+        if (pos == null)
+            return;
+        this.position = ErrorPosition.fromSpoonPosition(pos);
+        this.file = pos.getFile().getPath();
+    }
+
     public String getFile() {
         return file;
     }

liquidjava-verifier/src/main/java/liquidjava/diagnostics/errors/ArgumentMismatchError.java

@@ -0,0 +1,21 @@
+package liquidjava.diagnostics.errors;
+
+import liquidjava.diagnostics.TranslationTable;
+import spoon.reflect.cu.SourcePosition;
+
+/**
+ * Error indicating that the arguments provided to a function or method do not match the expected parameters either in
+ * number or type of arguments
+ * 
+ * @see LJError
+ */
+public class ArgumentMismatchError extends LJError {
+
+    public ArgumentMismatchError(String message) {
+        super("Argument Mismatch Error", message, null, null);
+    }
+
+    public ArgumentMismatchError(String message, SourcePosition position, TranslationTable translationTable) {
+        super("Argument Mismatch Error", message, position, translationTable);
+    }
+}