Add Custom Warning (#24)

Author: rcosta358

client/server/language-server-liquidjava.jar

@@ -28,7 +28,7 @@ export type LJError = CustomError | IllegalConstructorTransitionError |
     InvalidRefinementError | NotFoundError | RefinementError | StateConflictError | 
     StateRefinementError | SyntaxError;
 
-export type LJWarning = ExternalClassNotFoundWarning | ExternalMethodNotFoundWarning;
+export type LJWarning = CustomWarning | ExternalClassNotFoundWarning | ExternalMethodNotFoundWarning;
 
 type BaseDiagnostic = {
     title: string;
@@ -90,6 +90,11 @@ export type SyntaxError = BaseDiagnostic & {
     refinement: string;
 }
 
+export type CustomWarning = BaseDiagnostic & {
+    category: 'warning';
+    type: 'custom-warning';
+}
+
 export type ExternalClassNotFoundWarning = BaseDiagnostic & {
     category: 'warning';
     type: 'external-class-not-found-warning';

client/src/types/diagnostics.ts

@@ -59,7 +59,5 @@ export function renderError(error: LJError): string {
             const e = error as StateRefinementError;
             return `${header}${renderSection('Expected', `<pre>${e.expected}</pre>`)}${renderSection('Found', `<pre>${e.found}</pre>`)}${location}`;
         }
-        default:
-            return `${header}${location}`;
     }
 }

client/src/webview/renderers/diagnostics/errors.ts

@@ -29,7 +29,8 @@ export function renderWarning(warning: LJWarning): string {
             const e = warning as ExternalMethodNotFoundWarning;
             return `${header}${renderSection('Method', `<pre>${e.methodName}</pre>`)}${e.overloads.length > 0 ? renderSection("Overloads", `<pre>${e.overloads.join("\n")}</pre>`) : ""}${location}`;
         }
-        default:
+        case 'custom-warning': {
             return `${header}${location}`;
+        }
     }
 }

client/src/webview/renderers/diagnostics/warnings.ts

@@ -12,6 +12,7 @@
 import dtos.errors.StateConflictErrorDTO;
 import dtos.errors.StateRefinementErrorDTO;
 import dtos.errors.SyntaxErrorDTO;
+import dtos.warnings.CustomWarningDTO;
 import dtos.warnings.ExternalClassNotFoundWarningDTO;
 import dtos.warnings.ExternalMethodNotFoundWarningDTO;
 import dtos.warnings.LJWarningDTO;
@@ -25,6 +26,7 @@
 import liquidjava.diagnostics.errors.StateConflictError;
 import liquidjava.diagnostics.errors.StateRefinementError;
 import liquidjava.diagnostics.errors.SyntaxError;
+import liquidjava.diagnostics.warnings.CustomWarning;
 import liquidjava.diagnostics.warnings.ExternalClassNotFoundWarning;
 import liquidjava.diagnostics.warnings.ExternalMethodNotFoundWarning;
 import liquidjava.diagnostics.warnings.LJWarning;
@@ -60,6 +62,8 @@ public static Object convertToDTO(LJDiagnostic diagnostic) {
             return ExternalClassNotFoundWarningDTO.from(d);
         } else if (diagnostic instanceof ExternalMethodNotFoundWarning d) {
             return ExternalMethodNotFoundWarningDTO.from(d);
+        } else if (diagnostic instanceof CustomWarning d) {
+            return CustomWarningDTO.from(d);
         } else if (diagnostic instanceof LJError d) {
             return LJErrorDTO.from(d);
         } else if (diagnostic instanceof LJWarning d) {

server/src/main/java/dtos/DiagnosticConverter.java

@@ -13,6 +13,6 @@ public record RefinementErrorDTO(String category, String type, String title, Str
 
     public static RefinementErrorDTO from(RefinementError error) {
         return new RefinementErrorDTO("error", "refinement-error", error.getTitle(), error.getMessage(), error.getFile(),
-                error.getPosition(), TranslationTableDTO.from(error.getTranslationTable()), error.getExpected(), error.getFound());
+                error.getPosition(), TranslationTableDTO.from(error.getTranslationTable()), new ValDerivationNode(null, null), error.getFound());
     }
 }

server/src/main/java/dtos/errors/RefinementErrorDTO.java

@@ -0,0 +1,15 @@
+package dtos.warnings;
+
+import liquidjava.diagnostics.ErrorPosition;
+import liquidjava.diagnostics.warnings.CustomWarning;
+
+/**
+ * DTO for serializing CustomError instances to JSON
+ */
+public record CustomWarningDTO(String category, String type, String title, String message, String file, ErrorPosition position) {
+
+    public static CustomWarningDTO from(CustomWarning warning) {
+        return new CustomWarningDTO("warning", "custom-warning", warning.getTitle(), warning.getMessage(), warning.getFile(),
+                warning.getPosition());
+    }
+}